Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloadable products - Downloadable Information - Link design issue #18854

Closed
saphaljha opened this issue Oct 27, 2018 · 7 comments
Closed

Downloadable products - Downloadable Information - Link design issue #18854

saphaljha opened this issue Oct 27, 2018 · 7 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@saphaljha
Copy link
Contributor

Preconditions (*)

  1. Magento 2.3-develop
  2. PHP 7.1.22

Steps to reproduce (*)

  1. Create new downloadable product
  2. Go to "Downloadable Information" tab > Click on "Add link" button for Links and Samples as well, You will see the table header will be messy.

Expected result (*)

expected-download-products-inventory-catalog-magento-admin

Actual result (*)

actual-download-products-inventory-catalog-magento-admin

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @saphaljha. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@saphaljha do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@speedy008 speedy008 self-assigned this Oct 27, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 27, 2018

Hi @speedy008. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@okorshenko
Copy link
Contributor

Hi @saphaljha. Thank you for your report.
The issue has been fixed in #18856 by @speedy008 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@vasilii-b
Copy link

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b, here is your Magento instance.
Admin access: http://34.228.235.121/i-18854-2-2-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 13, 2018
@ghost ghost unassigned speedy008 Nov 13, 2018
@ghost ghost closed this as completed Nov 13, 2018
@ghost ghost reopened this Nov 13, 2018
@ghost
Copy link

ghost commented Nov 30, 2018

Hi @saphaljha , thank you for you report, this issue has already fixed in 2.3-develop branch, and will be available on 2.3.1 release.

@ghost ghost closed this as completed Nov 30, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

5 participants