Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing asterisk for admin required fields #18904

Closed
dmytro-ch opened this issue Oct 28, 2018 · 12 comments
Closed

Missing asterisk for admin required fields #18904

dmytro-ch opened this issue Oct 28, 2018 · 12 comments
Assignees
@rogyar @dmytro-ch
Labels
Component: Ui Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@dmytro-ch
Copy link
Contributor

dmytro-ch commented Oct 28, 2018 •
edited
Loading

There is a missing asterisk for admin required fields.
The issue has been already fixed for Magento 2.3.

Preconditions (*)

  1. Magento v.2.2.7

Steps to reproduce (*)

  1. Check the admin form with required fields. (E.g. Admin login page, admin order create page etc.)

Expected result (*)

  1. The asterisk is shown for the required foelds.

screen shot 2018-10-28 at 12 26 13 pm

screen shot 2018-10-28 at 12 33 27 pm

Actual result (*)

  1. The asterisk is not available for the required fields.

screen shot 2018-10-28 at 12 47 45 pm

screen shot 2018-10-28 at 12 36 07 pm

Possible solution

Looks like the issue was accidentally caused by the following commit: 7d4721d

  1. The same fix should be applied as for the Magento 2.3 in order to fix the issue: eb173dd
  2. Also, the following temporary fix for admin login form should be reverted: af70049
@dmytro-ch dmytro-ch self-assigned this Oct 28, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 28, 2018 •
edited by dmytro-ch
Loading

Hi @dmytro-ch. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@dmytro-ch do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 28, 2018
@dmytro-ch dmytro-ch added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Oct 28, 2018
dmytro-ch added a commit to dmytro-ch/magento2 that referenced this issue Oct 28, 2018
@dmytro-ch
Fix the issue with missing asterisk for admin required fields magento…
38bfe66 
…#18904
@dmytro-ch dmytro-ch mentioned this issue Oct 28, 2018
Merged
4 tasks
@rogyar
Copy link
Contributor

rogyar commented Oct 28, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18904-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar rogyar self-assigned this Oct 30, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 30, 2018 •
edited by rogyar
Loading

Hi @rogyar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@rogyar rogyar added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Ui labels Oct 30, 2018
@rogyar
Copy link
Contributor

rogyar commented Oct 30, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@rogyar
Copy link
Contributor

rogyar commented Oct 30, 2018

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18904-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar rogyar added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Oct 30, 2018
@magento-engcom-team
Copy link
Contributor

@rogyar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96014 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 30, 2018
dmytro-ch added a commit to dmytro-ch/magento2 that referenced this issue Nov 1, 2018
@dmytro-ch
Fix the functional tests failures magento#18904
7d2dd65
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your report.
The issue has been fixed in #18905 by @dmytro-ch in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogyar rogyar

@dmytro-ch dmytro-ch

Labels
Component: Ui Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rogyar @dmytro-ch @magento-engcom-team