Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product added to shopping cart / comparison list message not translated by default #18931

Closed
arnoudhgz opened this issue Oct 29, 2018 · 12 comments
Closed

Product added to shopping cart / comparison list message not translated by default #18931

arnoudhgz opened this issue Oct 29, 2018 · 12 comments
Labels
Component: Catalog Component: Checkout Event: mm18nyc Event: squashtoberfest Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@arnoudhgz
Copy link
Contributor

arnoudhgz commented Oct 29, 2018 •
edited
Loading

Currently the message that you have added something to your cart is not available in the i18n translation file.

Preconditions (*)

  1. Magento 2.2.6
  2. Non English store
  3. Any environment

Steps to reproduce (*)

  1. Add product to cart
  2. See "You added %1 to your shopping cart."
  3. Add product to comparison list
  4. See "You added product %1 to the comparison list."

Expected result (*)

  1. Strings available in app/code/Magento/Checkout/i18n/en_US.csv and app/code/Magento/Catalog/i18n/en_US.csv

Actual result (*)

  1. Strings not available in app/code/Magento/Checkout/i18n/en_US.csv and app/code/Magento/Catalog/i18n/en_US.csv

Tech hints

  1. Issue occurs since Magento 2.2.6
  2. These commits changed the string used for these messages: 3232465#diff-e4942136d5aba114e8b2c0529c0a040d & edd6062
  3. You added %1 to your <a href="%2">shopping cart</a>. should be added to app/code/Magento/Checkout/i18n/en_US.csv
  4. You added product %1 to the <a href="%2">comparison list</a>. should be added to app/code/Magento/Catalog/i18n/en_US.csv
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 29, 2018 •
edited by arnoudhgz
Loading

Hi @arnoudhgz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@arnoudhgz do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 29, 2018
@arnoudhgz arnoudhgz changed the title Product added to shopping cart message not translated by default Product added to shopping cart / comparison list message not translated by default Oct 29, 2018
@ghost ghost self-assigned this Oct 30, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 30, 2018 •
edited by ghost
Loading

Hi @ayazwebkul. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 30, 2018
@ghost
Copy link

ghost commented Oct 30, 2018

#SQUASHTOBERFEST

@ghost ghost mentioned this issue Oct 30, 2018
Merged
4 tasks
@ghost ghost added Component: Checkout Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release and removed Component: Translation labels Oct 30, 2018
@ghost
Copy link

ghost commented Oct 31, 2018

#mm18nyc

@magento-engcom-team
Copy link
Contributor

@sundarcreosen thank you for joining. Please accept team invitation here and self-assign the issue.

@ghost ghost self-assigned this Oct 31, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 31, 2018 •
edited by ghost
Loading

Hi @sundarcreosen. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost
Copy link

ghost commented Oct 31, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sundarcreosen. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sundarcreosen, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18931-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@sidolov
Copy link
Contributor

sidolov commented Nov 6, 2018

Hi @arnoudhgz. Thank you for your report.
The issue has been fixed in #18938 by @ayazwebkul in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 6, 2018
@sidolov sidolov closed this as completed Nov 6, 2018
magento-engcom-team added a commit that referenced this issue Nov 6, 2018
@magento-engcom-team
ENGCOM-3345: issue #18931 fixed. #18938
1954cf2 
 - Merge Pull Request #18938 from ayazwebkul/magento2:ayazmittaqi-18931
 - Merged commits:
   1. 4c25f0e
   2. d64351b
magento-engcom-team pushed a commit that referenced this issue Nov 6, 2018
ENGCOM-3345: issue #18931 fixed. #18938
5813463
JeroenVanLeusden pushed a commit to JeroenVanLeusden/magento2 that referenced this issue Nov 29, 2018
issue magento#18931 fixed.
3b521b0 
# Conflicts:
#	app/code/Magento/Catalog/i18n/en_US.csv
#	app/code/Magento/Checkout/i18n/en_US.csv
@JeroenVanLeusden JeroenVanLeusden mentioned this issue Nov 29, 2018
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your report.
The issue has been fixed in #19461 by @JeroenVanLeusden in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

magento-engcom-team added a commit that referenced this issue Jan 31, 2019
@magento-engcom-team
ENGCOM-4003: [Backport 2.2] issue #18931 fixed. #19461
720ee8c 
 - Merge Pull Request #19461 from JeroenVanLeusden/magento2:patch-1
 - Merged commits:
   1. 3b521b0
magento-engcom-team pushed a commit that referenced this issue Jan 31, 2019
@sidolov
ENGCOM-4003: [Backport 2.2] issue #18931 fixed. #19461
9a0806d
@apohutenumera
Copy link

Hi,
in 2.4, the message is still not translated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Catalog Component: Checkout Event: mm18nyc Event: squashtoberfest Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@arnoudhgz @sidolov @magento-engcom-team @apohutenumera and others