Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module detection not sensible enough #1910

Closed
Flyingmana opened this issue Sep 20, 2015 · 5 comments
Closed

Module detection not sensible enough #1910

Flyingmana opened this issue Sep 20, 2015 · 5 comments
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@Flyingmana
Copy link
Member

I have an module Cotya_Debug but had it inside a directory code/Cotya/DebugModule.

Thats obviously wrong, the module was not even loaded.
Still, the cli setup:upgrade command has listed it, so I did first not notice, I had named the Directoy wrong.

I use the "magento/product-community-edition": "1.0.0-beta2" release.

can someone reproduce this? maybe I just messed up my environment

@okorshenko okorshenko added the PS label Sep 21, 2015
@mazhalai
Copy link
Contributor

@Flyingmana can you clarify was this within app/code/Cotya/DebugModule?
Also did you create etc/module.xml as well as composer.json?

Thats obviously wrong, the module was not even loaded.

Can you clarify why? and how did you determine the module was not loaded?

@Flyingmana
Copy link
Member Author

the most obvious sign it was not loaded occurred while I debugged why my controller did not work. Dont know the exact place, but in the list of modules which was iterated, the module was not listed.

So simplest way to reproduce the Issue for me: Module name is Cotya/Debug
Have it in app/code/Cotya/DebugModule: route does not work.
Have it in app/code/Cotya/Debug: route does work

etc/module.xml does exist, and has ...<module name="Cotya_Debug" setup_version="0.1.1" >...

composer.json is also there, but I used the module via direct git checkout, which caused the mismatch in name.

Just tried it out again, the module is still listed on config->advanced->advanced->"disable module output"
Maybe it is only some parts which do not work, at least the frontend route does not work with the wrong named directory.

not important, still wanted to report it.
maybe someone adds a warning during setup or module:status command for this

@maksek maksek added the forum label Sep 30, 2015
@mazhalai
Copy link
Contributor

@Flyingmana we have created MAGETWO-43502 to investigate.

@mazhalai mazhalai added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Progress: needs update labels Sep 30, 2015
@davidalger davidalger removed the forum label Nov 10, 2015
@mazhalai
Copy link
Contributor

@Flyingmana do you still have this issue on latest 2.0.0?

@Flyingmana
Copy link
Member Author

No, Issue is not occuring anymore 👍

magento-team pushed a commit that referenced this issue Jan 22, 2018
…ta-migration

[obsessive-owls] MAGETWO-84648: Test automation for PageBuilder base functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants