Cannot connect to Magento 2 market place #19127

terrybakshi · 2018-11-09T07:48:00Z

Preconditions (*)

When going to websetup wizard, enter the private and secret key to login to magento market place to install extension
can't login getting error 200

Actual result (*)

[Screenshots, logs or description]

magento-engcom-team · 2018-11-09T07:48:02Z

Hi @terrybakshi. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@terrybakshi do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

terrybakshi · 2018-11-09T08:03:49Z

Summary of the issue
When going to websetup wizard, enter the private and secret key to login to magento market place to install extension can't login getting error 200

Preconditions
Magento 2.2.5
Php 7.1
Mysql 5.7

Environment Information
Magento 2.2.5 and 2.2.6 both on Different servers
Php 7.1
Mysql 5.7

Steps to reproduce
GO to system
Click web setup wizard
Click extension manager
Add Public key and Private Key
Click submit
Getting error Invalid response line returned from server: HTTP/2 200

Expected and actual results
Should login to extension manager to see and install extensions.

magento-engcom-team · 2018-11-09T08:04:47Z

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
6. Add label Issue: Confirmed once verification is complete.
7. Make sure that automatic system confirms that report has been added to the backlog.

terrybakshi · 2018-11-09T08:10:53Z

Component: XXXXX label(s) not sure how to do that

ghost · 2018-11-09T08:19:49Z

@magento-engcom-team give me 2.2.6 instance

magento-engcom-team · 2018-11-09T08:20:02Z

Hi @engcom-backlog-nazar. Thank you for your request. I'm working on Magento 2.2.6 instance for you

magento-engcom-team · 2018-11-09T08:20:37Z

Hi @engcom-backlog-nazar, here is your Magento instance.
Admin access: http://34.228.235.121/i-19127-2-2-6//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

ghost · 2018-11-09T08:22:33Z

Hi @terrybakshi i'm not able to reproduce this on clean magento instance. did you use some custom modules ?

ghost · 2018-11-09T08:29:48Z

@terrybakshi

terrybakshi · 2018-11-09T08:29:52Z

its not working when clicking on web setup wizard

ghost · 2018-11-09T08:30:29Z

@terrybakshi yes on this instances this page not working.

terrybakshi · 2018-11-09T08:32:41Z

i have 3 websites running on 2 different servers and all having same issue. no custom modules installed.

ghost · 2018-11-09T08:34:23Z

@terrybakshi seems like you have wrong http protocol versions https://developers.google.com/web/fundamentals/performance/http2/

ghost · 2018-11-09T08:35:18Z

@terrybakshi your hosting provider uses HTTP/1 instead of HTTP//2

terrybakshi · 2018-11-09T09:35:56Z

how do i fix this

ghost · 2018-11-09T09:42:21Z

@terrybakshi you should to contact your hosting provider and set to use HTTP/2

terrybakshi · 2018-11-09T09:56:52Z

ok i enabled HTTP/2 in apache modules and restarted the server and still getting same error

ghost · 2018-11-09T09:59:38Z

@terrybakshi Try do the cache clean, cache flush, and did you try reproduce this on local instance ?

terrybakshi · 2018-11-09T11:27:54Z

Ok did that even run the commands to upgrade, cache clean and cache flush still same issue.

ghost · 2018-11-09T11:36:41Z

@terrybakshi hmm very strange, the error you have about the wrong version of http protocols, magento gives you right reponse HTTP/2 200 OK but you server only understand HTTP/1.1 200 ok

terrybakshi · 2018-11-09T11:38:03Z

could it be related to cloudflare cache

terrybakshi · 2018-11-09T11:41:45Z

unfortunately no i tired clearing cloudflare cache but still no luck

terrybakshi · 2018-11-09T11:43:16Z

another issue i am having is when go to make payment with stripe i get error (error occurred on the server. Please try to place the order again.)

ghost · 2018-11-09T11:54:54Z

@terrybakshi this may be relate to your configuration on server side. something with http protocols.

terrybakshi · 2018-11-09T11:58:07Z

but how can that be possible i have two servers and they are running 3 different websites and all of them have same issue.

ghost · 2018-11-09T11:59:20Z

@terrybakshi did you reinstall instance locally ? they may have the same configuration.

vovayatsyuk · 2018-11-09T13:13:26Z

Have the same bug. Looks like for some servers magento returns HTTP/1.1 200 OK and they works fine. But for some I get HTTP/2 200 and it's not working.

@engcom-backlog-nazar can you check the headers? Open lib/internal/Magento/Framework/HTTP/Client/Curl.php (OR vendor/magento/framework/HTTP/Client/Curl.php), and apply this patch:

--- lib/internal/Magento/Framework/HTTP/Client/Curl.php
+++ lib/internal/Magento/Framework/HTTP/Client/Curl.php
@@ -432,6 +432,7 @@
     {
         if ($this->_headerCount == 0) {
             $line = explode(" ", trim($data), 3);
+            \Zend_Debug::dump($data);die;
             if (count($line) != 3) {
                 $this->doError("Invalid response line returned from server: " . $data);
             }

Then try to login and check response in Chrome network panel. I bet you'll have HTTP/1.1 200 OK

vovayatsyuk · 2018-11-09T13:19:40Z

Additionally, Magento uses Zend_Http_Response in some other places. It's not works too because of the following check:

/vendor/magento/zendframework1/library/Zend/Http/Response.php#517:

preg_match('#^HTTP/\d+(?:\.\d+) [1-5]\d+#', $line)

HTTP/1.1 200 OK - matches this expression
HTTP/2 200 - doesn't match this expression

ghost · 2018-11-09T13:20:27Z

Hi @vovayatsyuk seems like magento not support HTTP/2

ghost · 2018-11-09T13:48:00Z

@vovayatsyuk this can be a feature request, It will be processed faster if you move this to https://github.com/magento/community-features

vovayatsyuk · 2018-11-09T14:57:21Z

@terrybakshi here is a patch that removes invalid validator:

--- a/lib/internal/Magento/Framework/HTTP/Client/Curl.php
+++ b/lib/internal/Magento/Framework/HTTP/Client/Curl.php
@@ -432,7 +432,7 @@ class Curl implements \Magento\Framework\HTTP\ClientInterface
     protected function parseHeaders($ch, $data)
     {
         if ($this->_headerCount == 0) {
             $line = explode(" ", trim($data), 3);
-            if (count($line) != 3) {
+            if (count($line) < 2) {
                 $this->doError("Invalid response line returned from server: " . $data);
             }
             $this->_responseStatus = intval($line[1]);

costastsoukas · 2018-11-09T21:07:23Z

@vovayatsyuk You rock! Thank you!!

terrybakshi · 2018-11-09T21:43:15Z

@vovayatsyuk where should i apply this patch

vovayatsyuk · 2018-11-10T09:04:41Z

@terrybakshi the file may be in lib/internal/Magento/Framework/HTTP/Client/Curl.php or vendor/magento/framework/HTTP/Client/Curl.php

terrybakshi · 2018-11-10T09:35:11Z

@vovayatsyuk Thanks so much it worked

terrybakshi · 2018-11-10T09:35:49Z

i think its better magento team should fix this issue

magento-engcom-team · 2018-11-14T22:55:13Z

Hi @terrybakshi. Thank you for your report.
The issue has been fixed in #19143 by @vovayatsyuk in 2.3-develop branch
Related commit(s):

e827b3220c12cc8e793e0486cd9425e4ca4c2853

The fix will be available with the upcoming 2.3.1 release.

3615helloworld · 2018-11-21T01:44:37Z

Hi guys!
I have applied the fix but the issue is still here:
the error message is not displayed but the page keeps on loading and never sign in...

@vovayatsyuk Is there something else to add to make this work?

Thanks!

magento-engcom-team · 2018-11-30T15:40:10Z

Hi @terrybakshi. Thank you for your report.
The issue has been fixed in #19239 by @gelanivishal in 2.2-develop branch
Related commit(s):

ebe4af7f2b210b33cba727b10f6321746a071956

The fix will be available with the upcoming 2.2.8 release.

terrybakshi · 2019-02-19T07:01:34Z

This issue still exist in 2.2.7 not fixed in 2.2.7

terrybakshi · 2019-02-19T08:49:39Z

@vovayatsyuk This issue still exist in 2.2.7 not fixed in 2.2.7 is there a patch for this as well, i check they will fix the issue in 2.2.8 but how can we update magento to 2.2.8 if web setup wizard is not working

vovayatsyuk · 2019-02-19T08:56:26Z

@terrybakshi you can try to update Magento via command line interface.

The link to the patch that fixes the issue is mentioned in #19127 (comment).

View patch.

ghost · 2019-03-04T13:47:04Z

Magento 2.3 same issue exist in 2.3 not fixed in 2.3

aaj · 2019-03-21T20:50:42Z

Fresh install of 2.3 using Softaculous installer from a2 hosting. Same bug.

vovayatsyuk · 2019-03-22T05:45:10Z

Yes, it’s not fixed yet. These badges “fixed in..” are little confusing. They meant that the bug is fixed in develop branch.

As was mentioned above, the fix will be included on the next release.

adarshkhatri · 2019-07-02T04:50:51Z

I am doing curl connection to third-party API in 2.3 version. And confirm I am getting this error.

And patch does work.

magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 9, 2018

ghost self-assigned this Nov 9, 2018

ghost closed this as completed Nov 9, 2018

ghost added the feature request label Nov 9, 2018

vovayatsyuk mentioned this issue Nov 10, 2018

Allow to read HTTP/2 response header in curl client. #19143

Merged

4 tasks

magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 14, 2018

gelanivishal mentioned this issue Nov 16, 2018

[Backport] Allow to read HTTP/2 response header. #19239

Merged

4 tasks

3615helloworld mentioned this issue Nov 21, 2018

Marketplace does not sync: Invalid response line returned from server: HTTP/2 200 + Infinite Loop #19319

Closed

magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 30, 2018

Nazar65 mentioned this issue Dec 24, 2018

MAGENTO MARKETPLACE CONNECT HTTP2/200 /401 ERROR #19962

Closed

This issue was closed.

Cannot connect to Magento 2 market place #19127

Cannot connect to Magento 2 market place #19127

Comments

terrybakshi commented Nov 9, 2018

Preconditions (*)

Actual result (*)

magento-engcom-team commented Nov 9, 2018

terrybakshi commented Nov 9, 2018 • edited Loading

magento-engcom-team commented Nov 9, 2018 • edited by ghost Loading

terrybakshi commented Nov 9, 2018

ghost commented Nov 9, 2018

magento-engcom-team commented Nov 9, 2018

magento-engcom-team commented Nov 9, 2018

ghost commented Nov 9, 2018 • edited by ghost Loading

ghost commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

ghost commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

ghost commented Nov 9, 2018

ghost commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

ghost commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

ghost commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

ghost commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

ghost commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

ghost commented Nov 9, 2018

vovayatsyuk commented Nov 9, 2018 • edited Loading

vovayatsyuk commented Nov 9, 2018 • edited Loading

ghost commented Nov 9, 2018

ghost commented Nov 9, 2018

vovayatsyuk commented Nov 9, 2018 • edited Loading

costastsoukas commented Nov 9, 2018

terrybakshi commented Nov 9, 2018

vovayatsyuk commented Nov 10, 2018

terrybakshi commented Nov 10, 2018

terrybakshi commented Nov 10, 2018

magento-engcom-team commented Nov 14, 2018

3615helloworld commented Nov 21, 2018 • edited Loading

magento-engcom-team commented Nov 30, 2018

terrybakshi commented Feb 19, 2019

terrybakshi commented Feb 19, 2019

vovayatsyuk commented Feb 19, 2019

ghost commented Mar 4, 2019

aaj commented Mar 21, 2019

vovayatsyuk commented Mar 22, 2019

adarshkhatri commented Jul 2, 2019

terrybakshi commented Nov 9, 2018 •

edited

Loading

magento-engcom-team commented Nov 9, 2018 •

edited by ghost

Loading

ghost commented Nov 9, 2018 •

edited by ghost

Loading

vovayatsyuk commented Nov 9, 2018 •

edited

Loading

vovayatsyuk commented Nov 9, 2018 •

edited

Loading

vovayatsyuk commented Nov 9, 2018 •

edited

Loading

3615helloworld commented Nov 21, 2018 •

edited

Loading