Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.3 Shopping Cart Taxes Missing Calc Line #19701

Closed
Rjgoolsby opened this issue Dec 11, 2018 · 12 comments
Closed

Magento 2.3 Shopping Cart Taxes Missing Calc Line #19701

Rjgoolsby opened this issue Dec 11, 2018 · 12 comments
Assignees
Labels
Component: Tax Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Rjgoolsby
Copy link

Rjgoolsby commented Dec 11, 2018

Preconditions (*)

  1. Magento 2.3

Steps to reproduce (*)

  1. Create Tax Rules with at least TWO rules.
  2. Make sure "Calculate Off Subtotal Only" is checked for both rules.
  3. Select the SAME Product Tax Class. We want to apply two separate taxes to product and we want them based off the subtotal.
  4. Create Virtual Product. (Important as there's no shipping with this store. Everything is pickup in store).
  5. Add Selected Tax class from above to product.
  6. Add Product to Cart.

Expected result (*)

  1. Tax Calculations should be broken out for guest to see
  2. Tax Calculation is missing for last line. Calculation is correct. I verified the math but it's not showing up on the screen. See Screenshot
    screen shot 2018-12-11 at 1 11 47 am

Actual result (*)

  1. Calculation is correct but the totals aren't correctly showing up. Hospitality Tax should equal $0.36
  2. SC Sales Tax should equal $1.26.
  3. Total is correct at $1.62. But not displaying correctly in summary.

Confirm this is desired activity or a bug?

@magento-engcom-team
Copy link
Contributor

Hi @Rjgoolsby. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@Rjgoolsby do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 11, 2018
@ghost ghost self-assigned this Dec 11, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 11, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Dec 11, 2018
@ghost
Copy link

ghost commented Dec 11, 2018

Hi @Rjgoolsby Tax rules available only on EE version.
@Rjgoolsby , thank you for your report. Please follow these guidelines for proper tracking of your issue. You can report Commerce-related issues in one of two ways:
You can use the Support portal associated with your account
or
If you are a Partner reporting on behalf of a merchant, use the Partner portal.

GitHub is intended for Magento Open Source users to report on issues related to Open Source only. There are no account management services associated with GitHub.

@ghost ghost closed this as completed Dec 11, 2018
@Rjgoolsby
Copy link
Author

Rjgoolsby commented Dec 11, 2018

@engcom-backlog-nazar I'm using Magento Community Edition. What do you mean Tax Rules are only in EE. I have screen shots showing it's available in the community edition. Please re-open ticket

@Rjgoolsby
Copy link
Author

@engcom-backlog-nazar Is this a bot or a real person?
Here's proof that Tax Rules aren't a EE feature

https://docs.magento.com/m2/ce/user_guide/tax/tax-rules.html

These are the CE (Community Edition) User Docs. Please re-open ticket or specify whether this is desired behavior or a bug.

@ghost ghost reopened this Dec 12, 2018
@ghost ghost added Component: Tax Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 12, 2018
@ghost
Copy link

ghost commented Dec 12, 2018

hi @Rjgoolsby sorry for i misunderstood how apply 2 taxes from your description, now i'm able to reproduce it.
selection_234

@ghost ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 12, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97092, MAGETWO-97093 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 12, 2018
@ghost ghost removed their assignment Dec 12, 2018
@Rjgoolsby
Copy link
Author

@engcom-backlog-nazar. Thanks. No worries. I know you all get a lot of these and it has to be hard to sort through them all. We're just upgrading to 2.3 so I figured I would help by posting things we encounter to help. Again thanks!!!

@suryakant-krish suryakant-krish self-assigned this Dec 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@suryakant-krish suryakant-krish removed their assignment Dec 15, 2018
@niravkrish niravkrish self-assigned this Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @niravkrish. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@magento-engcom-team
Copy link
Contributor

Hi @Rjgoolsby. Thank you for your report.
The issue has been fixed in #21961 by @hiren0241 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tax Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants