Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store switcher not aligned proper in tab view #20158

Closed
cedarvinda opened this issue Jan 10, 2019 · 6 comments · Fixed by #20160
Closed

Store switcher not aligned proper in tab view #20158

cedarvinda opened this issue Jan 10, 2019 · 6 comments · Fixed by #20160
Labels
Area: Design/Frontend Component: Store Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@cedarvinda
Copy link
Member

cedarvinda commented Jan 10, 2019

Store switcher not aligned proper in tab view

Preconditions (*)

  1. Magento 2.3.0
  2. PHP 7.2

Steps to reproduce (*)

Step 1: Go to frontend
Step 2: view in responsive view (device with 991px)
Step 3: Now you will get issue (will appear horizontal scroll)

Expected result (*)

sol

Actual result (*)

issue

@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@cedarvinda do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 10, 2019
@shikhamis11 shikhamis11 self-assigned this Jan 10, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 10, 2019

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11
Copy link
Member

shikhamis11 commented Jan 10, 2019

@magento-engcom-team give me 2.3-develop instance

@shikhamis11 shikhamis11 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Store Area: Design/Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 10, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 10, 2019
@magento-engcom-team
Copy link
Contributor

@shikhamis11 Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97542, MAGETWO-97543 were created

@cedarvinda cedarvinda changed the title Store switcher not alined proper in tab view Store switcher not aligned proper in tab view Jan 10, 2019
@shikhamis11 shikhamis11 added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Jan 10, 2019
@shikhamis11 shikhamis11 removed their assignment Jan 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your report.
The issue has been fixed in #20160 by @cedarvinda in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 16, 2019
magento-engcom-team added a commit that referenced this issue Jan 16, 2019
…tab view #20160

 - Merge Pull Request #20160 from cedarvinda/magento2:Magento2.3-develop-PR12
 - Merged commits:
   1. c060b57
magento-engcom-team added a commit that referenced this issue Jan 16, 2019
…tab view #20160

 - Merge Pull Request #20160 from cedarvinda/magento2:Magento2.3-develop-PR12
 - Merged commits:
   1. c060b57
   2. 1e7bae1
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your report.
The issue has been fixed in #20325 by @shikhamis11 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Component: Store Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants