[Performance] Redis has more Network Traffic

[larsroettig]

Preconditions (*)

1. Install Magento 2.1.15 with bin/magento setup:perf:generate-fixtures ./setup/performance-toolkit/profiles/ee/medium.xml
2. Install Magento 2.1.8 with bin/magento setup:perf:generate-fixtures ./setup/performance-toolkit/profiles/ee/medium.xml
3. Setup redis for config and caching

Steps to reproduce (*)

1. bin/Magento c:f
2. Profile https://2.1.15.test/category-1.html
   --
3. cd Magento 2.1.8 && bin/magento c:f
4. Profile https://2.1.8.test/category-1.html

Expected result (*)

1. Not more Network Traffic

Actual result (*)

1. Currently you see 136% on Category more Network Traffic
   

Url: https://blackfire.io/profiles/compare/cfe9e28e-d5c1-466e-8467-344399c6939e/graph

Info:

Main Problem in 2.1.15 is the new Encryptor the it increases the network traffic +30% this is called up 5 dependent on site

Class: \Magento\Config\App\Config\Type\System

The Problem is worst if you have many configurations because the implementation of the Encryptor is exponentially

A Cart site call 5 times Redis give my all config data (edited)

If you have a Redis Cluster not on the same server this add network latency and if you have many request you can't handle this network traffic

Currently, i reproduce this issue in 2.1.x I add information about 2.3.x

[magento-engcom-team]

Hi @larsroettig. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@larsroettig do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[kandy]

@larsroettig, I agree that increasing of data stored in the cache is bad behavior.
But we decided on it due to security and performance reason.
Do you think there a way how to better implement it?

[larsroettig]

Hi @kandy,
most Redis clusters are behind a Firewall I understand the point with security. Because if the Redis Content for whatever reason is stolen passwords are not encrypted.

A private $cache can help because it is a singleton object for a checkout site you ask 5 times Redis what is the config for this one request.

Maybe we can spilt the config by obscure than it will be not so worst.

[david-fuehr]

Hi @kandy,

since the 2.1.14 update we experienced a massive network traffic increase in our redis node. After some investigation we could identify these changes as root cause.

As the effects are bigger than expected, I will provide you some data:

1. with active and warmed caches the store configuration read from redis is about 33% bigger than without encryption
2. in our AWS setup the network in (bytes) is increased by about 50% with moderate request count and system config encryption
3. with higher request count and a complete cache drop the same metric is about 8 times higher with encryption of system config

To proof that the introduction of encryption in \Magento\Config\App\Config\Type\System causes this effect, we reverted the changes in this class and could completely revert the network traffic increase.

Considering what @larsroettig said, I currently see two possible solutions:

1. Sensitive data such as passwords etc could be held in an additional object that is stored encrypted in redis.
2. A configuration in env.php could determine, whether the system configuration is being encrypted or not.

I tend to prefer the latter solution. It seems simpler and should be suitable for basic Magento setups (shared hosting, no firewall, low to medium traffic) to ensure safety with encrypted system configuration as well as more complex setups (managed hosting, firewall, medium to high traffic) without encryption.

What do you think?

[magento-engcom-team]

Hi @buskamuza. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• Next steps are available in case you are a member of Community Maintainers.

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

Hi @kandy. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• Next steps are available in case you are a member of Community Maintainers.

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[PascalBrouwers]

I also see allot of calls to $this->encryptor in combination with Redis. We are testing now without Redis to see the performance difference.