Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Tax Rate Search Filter - SQLSTATE[23000] #21521

Closed
robyerevan opened this issue Mar 1, 2019 · 17 comments
Closed

Broken Tax Rate Search Filter - SQLSTATE[23000] #21521

robyerevan opened this issue Mar 1, 2019 · 17 comments
Assignees
Labels
Component: Admin Component: Tax Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@robyerevan
Copy link

robyerevan commented Mar 1, 2019

Preconditions (*)

  1. Magento 2.2.3

Steps to reproduce (*)

  1. Go to Admin -> Stores -> Taxes -> Tax Rules
  2. Add a tax rule
  3. Search tax rule using both Name and Tax Rate fields
    eg. Name = Alabama & Tax Rate = US-AL

Expected result (*)

  1. Combined search executed and output is displayed to admin
  2. Admin can continue using tax rate search again

Actual result (*)

  1. MySQL error is thrown

Exception #0 (Zend_Db_Statement_Exception): SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'code' in where clause is ambiguous, query was: SELECT COUNT(DISTINCT main_table.tax_calculation_rule_id) FROM tax_calculation_rule AS main_table
LEFT JOIN tax_calculation AS tc ON main_table.tax_calculation_rule_id = tc.tax_calculation_rule_id
LEFT JOIN tax_calculation_rate AS rc ON tc.tax_calculation_rate_id = rc.tax_calculation_rate_id WHERE ((code LIKE '%Alabama%')) AND ((rc.code LIKE '%US-AL%'))

  1. In production mode blank area displayed instead of grid, admin can not use tax rate search anymore until session/cookies cleared manually
    tax_rules_page_crush
@magento-engcom-team
Copy link
Contributor

Hi @robyerevan. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@robyerevan do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 1, 2019
@robyerevan
Copy link
Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @robyerevan. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @robyerevan, here is your Magento instance.
Admin access: https://i-21521-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@robyerevan
Copy link
Author

Reproduced on
Magento 2.3-develop instance

dev-2 3-develop

@krishprakash krishprakash self-assigned this Mar 1, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 1, 2019

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash krishprakash added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Tax Component: Admin labels Mar 1, 2019
@krishprakash
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-21521-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@krishprakash krishprakash added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Mar 1, 2019
@krishprakash krishprakash reopened this Mar 1, 2019
@magento magento deleted a comment from magento-engcom-team Mar 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-21521-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@krishprakash krishprakash added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Mar 1, 2019
@amol2jcommerce
Copy link
Contributor

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce, here is your Magento instance.
Admin access: https://i-21521-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11 shikhamis11 self-assigned this Mar 1, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 1, 2019

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11 shikhamis11 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 1, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98517, MAGETWO-98518 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @robyerevan. Thank you for your report.
The issue has been fixed in #21701 by @tuyennn in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 14, 2019
magento-engcom-team added a commit that referenced this issue Mar 14, 2019
 - Merge Pull Request #21701 from tuyennn/magento2:2.3-issues-21521
 - Merged commits:
   1. 924dca2
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @robyerevan. Thank you for your report.
The issue has been fixed in #21535 by @tuyennn in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

magento-engcom-team added a commit that referenced this issue Apr 3, 2019
 - Merge Pull Request #21535 from tuyennn/magento2:issues-21521
 - Merged commits:
   1. d935998
   2. fb2d354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Component: Tax Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants