Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The variable name «categorySetup» in \Magento\Catalog\Setup\InstallData::install() method is misleading because $categorySetup->installEntities() installs both the products and categories attributes #2163

Closed
dmitrii-fediuk opened this issue Oct 22, 2015 · 1 comment
Closed

The variable name «categorySetup» in \Magento\Catalog\Setup\InstallData::install() method is misleading because $categorySetup->installEntities() installs both the products and categories attributes #2163

dmitrii-fediuk opened this issue Oct 22, 2015 · 1 comment
Assignees
@kandy
Labels
bug report

Comments

@dmitrii-fediuk
Copy link

magento2/app/code/Magento/Catalog/Setup/InstallData.php

Line 46 in 0be91a5

$categorySetup->installEntities();

Similar to #2162
@dmitrii-fediuk dmitrii-fediuk changed the title The variable name «categorySetup» in \Magento\Catalog\Setup\InstallData:install() method is misleading because $categorySetup->installEntities() installs both the products and categories attributes The variable name «categorySetup» in \Magento\Catalog\Setup\InstallData::install() method is misleading because $categorySetup->installEntities() installs both the products and categories attributes Oct 22, 2015
@vzabaznov
Copy link
Contributor

Closed as duplicate #1915

magento-engcom-team pushed a commit that referenced this issue Mar 5, 2018
Merge pull request #2163 from magento-plankton/MAGETWO-88698
00e2266 
[Plankton] Prepare code base 2.1.13
magento-engcom-team pushed a commit that referenced this issue Sep 12, 2018
@okolesnyk
Merge pull request #2163 from magento-pangolin/MSI-1616
eb86288 
Msi 1616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kandy kandy

Labels
bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dmitrii-fediuk @kandy @vkholoshenko @vzabaznov @MomotenkoNatalia