Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog_product_flat_data for store view populated with default view data when it should be store view data #21747

Closed
bengower opened this issue Mar 14, 2019 · 8 comments
Assignees
Labels
Component: Indexer Event: cdkyiv2019 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@bengower
Copy link

bengower commented Mar 14, 2019

Preconditions (*)

  1. A Magento CE 2.3 installation with multiple websites setup (I have four websites each setup with one store and one store view).
  2. Add a custom product attribute (Attribute A) with a ‘Catalog Input Type for Store Owner’ of Text Field, ‘Scope’ of Store View, ‘Allow HTML Tags on Storefront’ of Yes and ‘Used in Product Listing’ of Yes. Add it to an Attribute Set.
  3. Create a product (Product A) that uses the attribute set with this custom attribute in it. Add this product to all websites and enable it on all websites.
  4. Enable ‘Use Flat Catalog Product’ in Store > Configuration > Catalog > Catalog in the Storefront section.

Steps to reproduce (*)

  1. I open to edit Product A from Catalog > Products and add some text (‘Multi-buy Offer’) to the default view in Attribute A as I would like this text to appear on all but one site and then save.
  2. I then change the store view to that of one of the other store views (Store View 3). I go to Attribute A and untick ‘Use Default Value’ I then make sure the value of the Attribute A field is empty (just for this store view) and save.
  3. I then make sure that the indexes are up to date with the latest changes.

Expected result (*)

  1. The catalog product flat data table in the DB for the Store View 3 in the row for Product A contains Attribute A showing the empty value that was set for Store View 3.

Actual result (*)

  1. The catalog product flat data table in the DB for the Store View 3 in the row for Product A contains Attribute A but it shows the Default View value instead of empty value that was set for Store View 3.
  2. This incorrect value then appears on the frontend of the website associated with Store View 3

Disabling ‘Use Flat Catalog Product’ shows the correct data in Store View 3.

@magento-engcom-team
Copy link
Contributor

Hi @bengower. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@bengower do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 14, 2019
@bengower bengower changed the title catalog_product_flat_data populated with default view data when it should be store view data catalog_product_flat_data for store view populated with default view data when it should be store view data Mar 14, 2019
@bengower
Copy link
Author

@magento-engcom-team I can reproduce on a vanilla Magento instance.

@ghost ghost self-assigned this Mar 21, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 21, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Indexer Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 21, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98864, MAGETWO-98865 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 26, 2019
@Bravarg Bravarg self-assigned this Apr 13, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2019

Hi @OlehWolf. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@Bravarg
Copy link
Contributor

Bravarg commented Apr 13, 2019

To be more precisely, when you save product with indexer settings: "update on save" it saves data correctly on each store flat table. However after running bin/magento indexer:reindex it sets incorrect (default store view) data, instead of store view data.

@magento-engcom-team
Copy link
Contributor

Hi @bengower. Thank you for your report.
The issue has been fixed in #22318 by @OlehWolf in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 20, 2019
magento-engcom-team added a commit that referenced this issue Apr 20, 2019
… store during indexer #22318

 - Merge Pull Request #22318 from OlehWolf/magento2:21747-product-flat-data-store-values
 - Merged commits:
   1. ae7179f
magento-engcom-team added a commit that referenced this issue Apr 20, 2019
… store during indexer #22318

 - Merge Pull Request #22318 from OlehWolf/magento2:21747-product-flat-data-store-values
 - Merged commits:
   1. ae7179f
   2. 1a1eda6
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @bengower. Thank you for your report.
The issue has been fixed in #22581 by @maheshWebkul721 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

magento-engcom-team added a commit that referenced this issue May 28, 2019
…e value for store during indexer #22581

 - Merge Pull Request #22581 from maheshWebkul721/magento2:2.2-develop-PR-port-22318
 - Merged commits:
   1. 020f970
   2. aae1e59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Indexer Event: cdkyiv2019 Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants