Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout error for registered customer with cache_id_prefix on multi server setup #21842

Closed
david-fuehr opened this issue Mar 19, 2019 · 5 comments
Assignees
Labels
Component: Framework/Validator Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@david-fuehr
Copy link
Contributor

david-fuehr commented Mar 19, 2019

This issue comes from Magento\Framework\Validator\Factory::_initializeConfigList where absolute file paths are cached. The actual file content is evaluated using the local file system.

The method is used in \Magento\Customer\Model\ResourceModel\Address::_validate, \Magento\Quote\Model\CustomerManagement::validateAddresses and \Magento\Customer\Model\ResourceModel\Customer::_validate and thus the issue occurs whenever a customer, a customer_address or quote for a registered customer is saved.

We have a fix for this issue in use for quite some time where we stop caching the name of the files (currently two validation.xmls). I will soon open a pull request with these changes.

Preconditions

We experienced this issue from 2.1.8 and PHP 7.0 upwards to:

  1. Magento 2.3-develop
  2. PHP 7.2.13

Steps to reproduce (real life scenario)

  1. have a multi server setup with
    1. node backend (absolute instance dir: /var/www/backend/release/2019-02-28)
    2. node frontend-a (absolute instance dir: /var/www/frontend/release/2019-02-28)
    3. node frontend-b (absolute instance dir: /var/www/frontend/release/2019-03-01 - autospawned)
    4. node redis
    5. share cache for all Magento instances (identical id_prefix in cache section of env.php)
    6. [node mysql, ...]
  2. clear cache on backend node
  3. right after that save a customer or customer_address on the backend node (may be a cron job or similar)
  4. place an order with a registered customer on one of the frontend-nodes

Expected result

  1. The success page is being shown

Actual result

  1. The order can not be placed. An error is displayed:
The "/var/www/backend-2019-02-28/app/code/Magento/Eav/etc/validation.xml" file doesn't exist.

Development

For development purposes the setup can be simulated:

  1. set up a regular instance
  2. make sure that the id_prefix in env.php is defined
    'cache' => [
        'frontend' => [
            'default' => [
                'id_prefix' => '173_'
            ],
            'page_cache' => [
                'id_prefix' => '173_'
            ]
        ]
    ],
  1. redis may be used, the issue can also be reproduced using file based caching
  2. register a customer
  3. place an order using this customer
  4. move the instance directory to another path
  5. update webserver configuration accordingly and restart
  6. try to place an order with the same customer again
    1. expected: success page is being shown
    2. actual: error '[...]Magento/Eav/etc/validation.xml" file doesn't exist.'

Additional

Related PR: #14411 (2.1 - closed)

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 19, 2019

Hi @david-fuehr. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@david-fuehr do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 19, 2019
david-fuehr added a commit to david-fuehr/magento2 that referenced this issue Mar 19, 2019
Github issue: magento#21842

In customer and customer_address validation context the validator
factory no longer caches absolute file paths for the validation.xml
files (currently two file) as the file content is evaluated later
in the filesystem directly and the file paths may not be correct
in a multi server setup with shared cache (id_prefix)
@ghost ghost self-assigned this Mar 20, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 20, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Framework/Validator labels Mar 20, 2019
@ghost ghost added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 27, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 27, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98878, MAGETWO-98879 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@david-fuehr david-fuehr added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Mar 27, 2019
@ghost ghost assigned david-fuehr Mar 27, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 29, 2019
david-fuehr added a commit to david-fuehr/magento2 that referenced this issue May 7, 2019
Github issue: magento#21842

In customer and customer_address validation context the validator
factory no longer caches absolute file paths for the validation.xml
files (currently two file) as the file content is evaluated later
in the filesystem directly and the file paths may not be correct
in a multi server setup with shared cache (id_prefix)
david-fuehr added a commit to david-fuehr/magento2 that referenced this issue May 9, 2019
Github issue: magento#21842

In customer and customer_address validation context the validator
factory no longer caches absolute file paths for the validation.xml
files (currently two file) as the file content is evaluated later
in the filesystem directly and the file paths may not be correct
in a multi server setup with shared cache (id_prefix)
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @david-fuehr. Thank you for your report.
The issue has been fixed in #22805 by @david-fuehr in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Validator Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

2 participants