-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magento CRON Job Names are missing in NewRelic: "Transaction Names" #22047
Comments
Hi @PiotrSiejczuk. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @PiotrSiejczuk do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
I think that's great issue for tomorrow Magento Contribution Day with @magento/strix Extra information: |
@lbajsarowicz that is indeed the idea for this ticket :) Will pick it up and hopefully fix it in a few hours :) |
Question to @PiotrSiejczuk and @maghamed - what should be the depth of the NewRelic descriptions: |
Created PR #22059 for CLI commands. I'm not sure if we can achieve something that @PiotrSiejczuk asked, as usually Cron Jobs are ran in groups and I'm not sure if one PHP execution can contain multiple transactions. So that... I just added transaction name based on CLI command name. I'm doing investigation if we can have multiple transactions in one runtime. |
I am an old school guy, so, there is a Patch for normal CRON Flows:
Magento2.3.x-NewRelicCRONTransactionTrackingPatch.zip I am going to create a PR in a few moment too |
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
Hi @PiotrSiejczuk. Thank you for your report.
The fix will be available with the upcoming 2.3.2 release. |
Hi @magento-engcom-team, thank you for your information. Although commits from @lbajsarowicz are not addressing the whole scope of the reported issue. It is perfect that CLI CRON commands are being correctly Tracked @ NewRelic now. Although it is not tracking correctly ATOMIC Transactions executed within standard CRON execution. That being said: this ticket should not be CLOSED as the FIX is not addressing the whole scope of the ISSUE described initially |
Hi @PiotrSiejczuk. Thank you for your report. The fix will be available with the upcoming 2.4.0 release. |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Above screen has 2 transactions "hidden" with white box and red border due to project specific names and data that cannot be desclousered
Actual result (*)
The text was updated successfully, but these errors were encountered: