Backward-incompatible change between 2.2.7 and 2.2.8

[yutv]

Preconditions (*)

1. Magento 2.2.7 and Magento 2.2.8
2. PHP 7.1.10

Steps to reproduce (*)

1. Create a custom module in Magento 2.2.7 with the following class:
   app/code/Vendor/Module/Block/Product/View/Options/Type/Swatch.php

    <?php
   
    namespace Vendor\Module\Block\Product\View\Options\Type;
   
    use Magento\Catalog\Block\Product\View\Options\Type\Select;
   
    class Swatch extends Select
    {
        public function getValuesHtml()
        {
            $html = parent:getValuesHtml();
            // custom logic goes here
            return $html;
        }
    }
   

2. Check that this class doesn't cause PHP Fatal Error in Magento 2.2.7

3. Upgrade to Magento 2.2.8

Expected result (*)

1. No fatal error in custom module
2. Method declaration in Magento classes MUST NOT change between patch versions (e.g. 2.2.7 and 2.2.8)

Actual result (*)

1. Fatal error in custom module:

    Fatal error:  Declaration of Vendor\Module\Block\Product\View\Options\Type\Swatch::getValuesHtml() 
    must be compatible with Magento\Catalog\Block\Product\View\Options\Type\Select::getValuesHtml(): string 
    in app/code/Vendor/Module/Block/Product/View/Options/Type/Swatch.php on line 9
   

Backward-incompatible change

The issue caused by backward-incompatible commit between Magento 2.2.7 and 2.2.8 made by @rleshchenko.

The declaration of the getValuesHtml method was changed from:

public function getValuesHtml()

to:

public function getValuesHtml(): string

As result any class which extends this method in old declaration becomes incompatible with the new one and throws fatal error.

Note: Issue is still exists in the 2.2-develop branch: https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Catalog/Block/Product/View/Options/Type/Select.php#L62

[m2-assistant]

Hi @yutv. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@yutv do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[m2-assistant]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

@engcom-backlog-nazar Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

[m2-assistant]

Hi @VitaliyBoyko. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.
  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

[magento-engcom-team]

✅ Confirmed by @rogyar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99129 were created

Issue Available: @rogyar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[magento-engcom-team]

Hi @yutv. Thank you for your report.
The issue has been fixed in #22267 by @VitaliyBoyko in 2.2-develop branch
Related commit(s):

• 179bedf3de99244b384c97cf7b2be106967f47cf

The fix will be available with the upcoming 2.2.9 release.

[keyurk-emipro]

This backward-incompatibility reproduced again in between 2.3.1 and 2.3.2 but can not found on 2.3-dev branch, Is there anyone know when this resolved from 2.3?