Configurable Product Gallery Images Out of Order when More than 10 images

[sjb9774]

Preconditions (*)

1. Magento 2.3.1

Steps to reproduce (*)

1. Create a configurable product or use one from SampleData
2. Set up an attribute for use with the configurable product as a swatch
   
3. Edit one of the simple products related to that configurable product to have 10 or more images in its gallery (sometimes 11 images are required do to 0-indexed positions. I haven't looked into why they are sometimes 0-indexed and sometimes 1-indexed)
   
4. View that product through the configurable product detail page
   

Expected result (*)

1. Gallery images will appear in the same order as they are configured in the backend

Actual result (*)

1. Gallery images are in a different order than configured in the backend

Solution

This is due to the swatch-renderer.js file's _sortImages method not converting the image position values to integers first, thus sorting strings. Once you have a position of 10 or greater, you get strange orders because values of "1", "2", "10" are sorted to "1", "10", "2". Wrapping swatch-renderer.js line 700 with parseInt fixes the problem.

[m2-assistant]

Hi @sjb9774. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@sjb9774 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[m2-assistant]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[ghost]

Hi @sjb9774 thank you for you report, i'm not able to reproduce following steps you described, this issue may be related to your cache, please flush cache and try again. thank you for collaboration.

[sjb9774]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @sjb9774. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @sjb9774, here is your Magento instance.
Admin access: https://i-22249-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[sjb9774]

@magento-engcom-team Thanks for the GIF, I missed that the attribute your product variation is based on needs to be setup as a swatch. There are also some scenarios where the positions are 0-indexed instead of 1-indexed as I had locally so you could need to add 11 images total. I've reproduced this issue again on a 2.3-develop instance.

• Backend configuration
  
• Frontend display
  
• JS bug demonstration
  

[sjb9774]

I've updated the issue description to indicate the attribute needs to be setup as a swatch.

[ghost]

@sjb9774 thanks now clear 👍

[magento-engcom-team]

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99138 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[magento-engcom-team]

Hi @sjb9774. Thank you for your report.
The issue has been fixed in #22287 by @Wirson in 2.3-develop branch
Related commit(s):

• 700a1535cb6f58224e8e302ad1b4556d8a118e01

The fix will be available with the upcoming 2.3.3 release.

[magento-engcom-team]

Hi @sjb9774. Thank you for your report.
The issue has been fixed in #22288 by @Wirson in 2.2-develop branch
Related commit(s):

• f4ab0e6d9280920b6c64b789ec7a155330cfb681

The fix will be available with the upcoming 2.2.9 release.