2.2.8 Configurable product option dropdown - price difference incorrect when catalog prices are entered excluding tax

[danielpfarmer]

After upgrading to 2.2.8 we have noticed that configurable products that have only have one configurable attribute display a price increase in the dropdown of the tax amount. This seems to be only affecting stores when prices are entered excluding tax and configurable products with only one configurable attribute.

Preconditions (*)

1. Magento 2.2.8
2. Catalog Prices are EXCLUDING TAX (Stores > Configuration > Sales > Tax > Calculation Settings > Catalog Prices (Excluding Tax)

Steps to reproduce (*)

1. Create a configurable product with only one configurable attribute (e.g color).
2. Assign simple products to the configurable, and set all simples to be the same price.
3. Load configurable product page.
4. View options in the configurable attribute.

Expected result (*)

1. The attribute dropdown does not show an increase in price as all attached simples are the same price and tax is already rendered in the final price at the top of the page.

Actual result (*)

1. Observe that the dropdown displays an incorrect increase in price. It adds on the tax amount of the product onto the price increase when this is already rendered in the product final display price at the top of the page.

Magento 2.2.6 (Correct)

Magento 2.2.8 (Incorrect)

In this example, each simple product was added into Magento with a price of £150 and a special price of £122.49. The tax settings then add on an additional £24.50 (20% VAT).

[m2-assistant]

Hi @danielpfarmer. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@danielpfarmer do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[danielpfarmer]

Yes I can and just have replicated this on a vanilla instance of Magento 2.2.8 with sample data.

Steps to reproduce:

1. Install Magento 2.2.8 with sample data
2. Set stores > config > Sales > Shipping Settings > Origin = United Kindgom
3. Set stores > config > Sales > Tax > Calculation Settings > Tax Calculation Based On = Shipping Origin
4. Set stores > config > Sales > Tax > Price Display Settings > Display Product Prices In Catalog = Including Tax
5. Create new tax option for UK at 20%
6. Edited the Antonia Racer Tank to only be configurable size and adjusted the attached simples accordingly.

[m2-assistant]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[ghost]

Hi @danielpfarmer thank you for you report, this is expected behavior introduced in -> #17695

[hostep]

@engcom-backlog-nazar: closing this makes no sense, since this ticket is about seeing the taxes in the dropdown. This might be a regression introduced by #17695.

[ghost]

@hostep ok, the core issue that

EXCLUDING TAX (Stores > Configuration > Sales > Tax > Calculation Settings > Catalog Prices (Excluding Tax)

does not affect in prices of dropdown attribute ?

[hostep]

@engcom-backlog-nazar: not sure, haven't looked into the details yet, just reopened the issue because it looked like it was closed for the wrong reason.

Maybe @danielpfarmer can answer your question.

[danielpfarmer]

Hey @hostep @engcom-backlog-nazar

Yes this affects stores which have their prices inserted in the backend excluding tax, and then display prices including tax. Tax is added using the tax rules.

The problem:

Magento displays the product price including tax on the pdp.

The dropdown then shows a price increase, in this case of £24.50, which shouldnt be there as it is the product tax amount and is already included as part of the product price already displayed on the pdp.

This would make the customer think that the price is £146.99 + £24.50 (£171.49) when it isn't. It is only £146.99 in total.

Cheers

[magento-engcom-team]

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99231, MAGETWO-99232 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @danielpfarmer. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

[magento-engcom-team]

Hi @danielpfarmer. Thank you for your report.
The issue has been fixed in #22466 by @danielpfarmer in 2.3-develop branch
Related commit(s):

• d8d8fed62ea570359c6cc60227b338dbb79d00a2
• 11c31edf2b465f6a529ad26f03b708ab48625c22

The fix will be available with the upcoming 2.3.2 release.

[magento-engcom-team]

Hi @danielpfarmer. Thank you for your report.
The issue has been fixed in #22535 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

• f593573d6ea7e24017df911f595824bd812ff166

The fix will be available with the upcoming 2.2.9 release.

[drottendal]

This was not included in the 2.2.9 release.

https://github.com/magento/magento2/blob/2.2.9/app/code/Magento/ConfigurableProduct/view/frontend/web/js/configurable.js#L376

[hostep]

Good point @Naitaes. Sometimes the version mentioned in those automated comments is not correct unfortunately.
However it looks like it got included in Magento 2.2.10: https://github.com/magento/magento2/blob/2.2.10/app/code/Magento/ConfigurableProduct/view/frontend/web/js/configurable.js#L376

[seak6adtn59v]

I am having the same issue in Magento ver. 2.2.2. Is there any quick tip to fix this in v2.2.2 instead updating the whole magento version?

[danielpfarmer]

You should be keeping up to date to ensure the security of your website From: Prashant Kumar <notifications@github.com> Reply to: magento/magento2 <reply@reply.github.com> Date: Thursday, 30 January 2020 at 05:31 To: magento/magento2 <magento2@noreply.github.com> Cc: Daniel Farmer <dan@danielfarmer.co.uk>, Mention <mention@noreply.github.com> Subject: Re: [magento/magento2] 2.2.8 Configurable product option dropdown - price difference incorrect when catalog prices are entered excluding tax (#22270) I am having the same issue in Magento ver. 2.2.2. Is there any quick tip to fix this in v2.2.2 instead updating the whole magento version? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22270?email_source=notifications&email_token=AG6GR5YFGKHTRMMJBC7LW4DRAJQ35A5CNFSM4HE4R3IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKJXTFQ#issuecomment-580090262>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AG6GR5YK3WQZ3HGQKW45EPDRAJQ35ANCNFSM4HE4R3IA>.