Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeSniffer should not mark correctly aligned DocBlock elements as code style violation. #22317

Closed
p-bystritsky opened this issue Apr 13, 2019 · 3 comments
Assignees
Labels
Event: cdkyiv2019 Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@p-bystritsky
Copy link
Contributor

p-bystritsky commented Apr 13, 2019

Summary (*)

Magento\Sniffs\Annotation\MethodArgumentsSniff is marking as incorrect any aligned argument parameters, while Magento Devdocs is obviously declaring such format as valid.

Examples (*)

/**
* ...
*
* @param string $parentId
* @param string $childId
* @param int|null $position
* @return int
* @see _insertChild() for position explanation
*/

Proposed solution

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2019

Hi @p-bystritsky. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@p-bystritsky do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 13, 2019
@p-bystritsky p-bystritsky self-assigned this Apr 13, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2019

Hi @p-bystritsky. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.
    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

@p-bystritsky p-bystritsky changed the title CodeSniffer should not mark correctly aligned DocBlock elements as codestyle violation. CodeSniffer should not mark correctly aligned DocBlock elements as code style violation. Apr 13, 2019
p-bystritsky added a commit to p-bystritsky/magento2 that referenced this issue Apr 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your report.
The issue has been fixed in #22321 by @p-bystritsky in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 20, 2019
p-bystritsky added a commit to p-bystritsky/magento2 that referenced this issue Apr 21, 2019
p-bystritsky added a commit to p-bystritsky/magento2 that referenced this issue May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: cdkyiv2019 Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

2 participants