-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeSniffer should not mark correctly aligned DocBlock elements as code style violation. #22317
Comments
Hi @p-bystritsky. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @p-bystritsky do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @p-bystritsky. Thank you for working on this issue.
|
… elements as code style violation.
Hi @p-bystritsky. Thank you for your report. The fix will be available with the upcoming 2.3.2 release. |
… elements as code style violation.
Summary (*)
Magento\Sniffs\Annotation\MethodArgumentsSniff is marking as incorrect any aligned argument parameters, while Magento Devdocs is obviously declaring such format as valid.
Examples (*)
/**
* ...
*
* @param string $parentId
* @param string $childId
* @param int|null $position
* @return int
* @see _insertChild() for position explanation
*/
Proposed solution
The text was updated successfully, but these errors were encountered: