Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape HTML entities in URL #229

Closed
witrin opened this issue Feb 16, 2013 · 2 comments
Closed

Escape HTML entities in URL #229

witrin opened this issue Feb 16, 2013 · 2 comments

Comments

@witrin
Copy link

witrin commented Feb 16, 2013

Hi,

the helper method Mage_Core_Helper_Abstract::escapeUrl() doesn't prevent double encodings. So would be htmlspecialchars($data, ENT_COMPAT, 'UTF-8', false) not the better solution?

Best regards,
Artus

@magento-team
Copy link
Contributor

Hi, Artus.
Yes, similar to escapeHtml(), it should be OK to use it in escapeUrl() as well. We'd appreciate if you contribute with a unit test.

@verklov
Copy link
Contributor

verklov commented Jan 2, 2014

Fixed by #238 . Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants