Alert widget doesn't trigger always method on showing the message

[eduard13]

Preconditions (*)

1. Magento 2.3-develop

Steps to reproduce (*)

1. Create a new alert widget on frontend. The following simple code can be used:

require([
        'jquery',
        'Magento_Ui/js/modal/alert'
    ], function ($, alert) {
        'use strict';

        alert({
            title: 'Alert Title',
            content: 'content',
            modalClass: 'alert',
            actions: {
                always: function() {
                    console.log('always triggering');
                }
            }
        });
    });

2. Click OK button

Expected result (*)

1. You should be seeing always triggering text logged on opening and right after clicking the OK button

Actual result (*)

1. The always triggering text is logged twice right after clicking the OK button

Additional information

The fix proposed in #23234 was reverted.
The solution was created an additional critical issue with payments on checkout
Please see more details in this magento/security-package#207 (comment)

...
this.options.actions.always();  must be called after the user click on "Ok" button (not before)
So this line should be inside Magento_Ui/js/modal/confirm::closeModal() like it is in parent JS component https://github.com/magento/magento2ce/blob/2.4-develop/app/code/Magento/Ui/view/base/web/js/modal/confirm.js#L97

[m2-assistant]

Hi @eduard13. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@eduard13 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @eduard13. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.
  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @dmytro-ch. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @dmytro-ch
Thank you for verifying the issue. Based on the provided information internal tickets MC-17454, MC-17455 were created

Issue Available: @dmytro-ch, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[amol2jcommerce]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @amol2jcommerce, here is your Magento instance.
Admin access: https://i-23233-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[magento-engcom-team]

Hi @eduard13. Thank you for your report.
The issue has been fixed in #23234 by @eduard13 in 2.3-develop branch
Related commit(s):

• 0c402aedc254ca85864008f54d5d4b2545b605d0
• 10c89f7cab704d239ad666a01d0538bcfdfd812f
• 07590d9ed581b4f760bdd66135d5ca2a93704cf4
• 92adfeb2ebf9e2d27dc715ef4dcad8deddd2a4ad

The fix will be available with the upcoming 2.3.3 release.

[magento-engcom-team]

Hi @eduard13. Thank you for your report.
The issue has been fixed in #23579 by @eduard13 in 2.2-develop branch
Related commit(s):

• ecfaea17beafdfbd77f831cee29a819cad6c98ef
• 371755171cde37b2ef96f3b24758e427c0b93893
• 18a3f7021c2a35cc353c5d2e142420fa6d57cc79
• fc35128073722d72670262ba7aeffb1e63d09704

The fix will be available with the upcoming 2.2.10 release.

[slavvka]

#23579 has been reverted

[magento-engcom-team]

✅ Confirmed by @slavvka
Thank you for verifying the issue. Based on the provided information internal tickets MC-33532 were created

Issue Available: @slavvka, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

[magento-engcom-team]

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

Please feel free to comment or reopen according to the Issue reporting guidelines
the ticket if you are still facing this issue on the latest 2.x-develop branch. Thank you for collaboration.

[magento-engcom-team]

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

Please feel free to comment or reopen according to the Issue reporting guidelines
the ticket if you are still facing this issue on the latest 2.x-develop branch. Thank you for collaboration.