Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not the best user experience for reCPACTHA with PayPal if user does not check reCAPTHCA #207

Closed
sdzhepa opened this issue Apr 15, 2020 · 5 comments
Assignees
Labels
bug Something isn't working Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@sdzhepa
Copy link
Contributor

sdzhepa commented Apr 15, 2020

Preconditions (*)

  1. ReCaptcha v2(I am not a robot) is configured and enabled for PayPal on Checkout
  2. 2020-04-15_16-59-36

Steps to reproduce (*)

  1. Add any product to cart and start checkout
  2. Fill all required data on Shipping step and go next
  3. Select "Credit Card (Payflow Pro)" payment method
  4. Fill all required payment data
  5. DO NOT CHECK reCAPCTHA
  6. Click place order

Actual result (*)

  1. A pop-up window with an error message appears for a couple of seconds(2-5) and then the page automatically reloaded. All filed data were removed from fields
    See recording for more details: https://www.screencast.com/t/KyNxF3R2c

Expected result (*)

  • This point should be improved
  • Entered payment data should not be removed
  • Probably we can use JS validation, like "This is a required field" without full page reloading
  • or just error message in the red box(as for other errors during checkout) but without page reloading
  • not sure that pop-up is the best solution here but at least user should have possibility to read the message and click "OK" or "Cancel" buttons that shown on this pop-up
@sdzhepa sdzhepa added bug Something isn't working Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label labels Apr 15, 2020
@sdzhepa
Copy link
Contributor Author

sdzhepa commented Apr 15, 2020

@engcom-Delta could you please check how it worked on the previous Magento release.
I think can be used composer CE installation.

Just want to know this is something that we broke during our work - like regression bug
or behavior that was previously

@viktym
Copy link
Contributor

viktym commented Apr 16, 2020

The issue with disappearing pop-up is caused by magento/magento2#23234
A couple of weeks ago I had a conversation with the author of this PR @eduard13 and we agreed that it should be reverted.
this.options.actions.always();  must be called after the user click on "Ok" button (not before)
So this line should be inside Magento_Ui/js/modal/confirm::closeModal() like it is in parent JS component https://github.com/magento/magento2ce/blob/2.4-develop/app/code/Magento/Ui/view/base/web/js/modal/confirm.js#L97

Author of magento/magento2#23234 @eduard13 refused to revert his PR due to the lack of time.
@sdzhepa could you create an issue in https://github.com/magento/magento2/ and find someone who is willing to help with reverting this PR. Since it can potentially affect other Magento core functionality as well as 3-rd party extensions.

@sdzhepa
Copy link
Contributor Author

sdzhepa commented Apr 20, 2020

PR magento/magento2#23234 has been reverted.
@engcom-Delta could you please check this flow on the latest code?

@engcom-Delta
Copy link

@sdzhepa
I checked this flow and now user have possibility to read the message and click "OK"

Current behavior on the latest code:
reCAPTCHA v2 ("I am not a robot")
Peek 2020-04-22 10-10

reCAPTCHA v2 Invisible(with wrong Google API Secret Key)
Peek 2020-04-22 10-21

reCAPTCHA v3 Invisible(with wrong Google API Secret Key)
Peek 2020-04-22 10-31

@sdzhepa
Copy link
Contributor Author

sdzhepa commented Apr 22, 2020

Thank you @engcom-Delta

We can close this issue

@sdzhepa sdzhepa closed this as completed Apr 22, 2020
@sdzhepa sdzhepa added the Severity: S1 Affects critical data or functionality and forces users to employ a workaround. label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Development

No branches or pull requests

3 participants