Unable to save edited product when max_sale_qty is Magento's default

[sol0mandra]

Preconditions (*)

1. Install Magento Open Source 2.3.1

Steps to reproduce (*)

1. Go to admin area
2. Go to Stores->Configuration->Catalog->Inventory->Product Stock Options
3. Edit the global default to be 0
4. Save the config
5. Open create a simple product form and fill in minimum required data
6. Open the advanced inventory popup
7. Uncheck the checkbox "use_config_max_sale_qty"
8. Observe the default value of 0 in max_sale_qty field
9. Do not edit the default provided
10. Click Save

Expected result (*)

1. Product is successfully saved

Actual result (*)

1. Save is not happening, validation is failed due to validate-grater-then-0 on max_sale_qty field.

This value however comes from the cataloginventory's db_schema (module-catalog-inventory/etc/db_schema.xml):

<table name="cataloginventory_stock_item" resource="default" engine="innodb" comment="Cataloginventory Stock Item">
...
<column xsi:type="decimal" name="max_sale_qty" scale="4" precision="12" unsigned="false" **nullable="false"
                default="0"** comment="Max Sale Qty"/>
...
</table>

While in the same module, in magento/module-catalog-inventory/view/adminhtml/ui_component/product_form.xml:

<field name="max_sale_qty" formElement="input">
    <argument name="data" xsi:type="array">
        <item name="config" xsi:type="array">
            <item name="value" xsi:type="object">Magento\CatalogInventory\Model\Source\StockConfiguration</item>
        </item>
    </argument>
    <settings>
        <scopeLabel>[GLOBAL]</scopeLabel>
        <validation>
            <rule name="**validate-greater-than-zero**" xsi:type="boolean">true</rule>
        </validation>
        <label translate="true">Maximum Qty Allowed in Shopping Cart</label>
        <dataScope>max_sale_qty</dataScope>
    </settings>
</field>

And in the same module, inmodule-catalog-inventory/etc/adminhtml/system.xml:

<section id="cataloginventory" translate="label" type="text" sortOrder="50" showInDefault="1" showInWebsite="1" showInStore="1">
...
<group id="item_options" translate="label comment" type="text" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
...
<field id="max_sale_qty" translate="label" type="text" sortOrder="4" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                    <label>Maximum Qty Allowed in Shopping Cart</label>
                    <validate>**validate-number**</validate>
                </field>


So, there is inconsistency - if 0 is allowed as value for max_sale_qty. If 0 is set from the start as default, there shouldn't be validation that would forbid it on the frontend.

[m2-assistant]

Hi @eshwilk. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@eshwilk do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[sol0mandra]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @eshwilk. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @eshwilk, here is your Magento instance.
Admin access: https://i-23319-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[sol0mandra]

The problem manifests itself and is even more important if that's a project, where products are created programatically (like a lot of migration projects). Then the DB default of 0 for max_sale_qty is set for all freshly created products - and in this way breaking any editing of the products later on

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-17605, MC-17606 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.