Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer.xml & mview.xml doesn't allow numbers in vendor name and class name #24323

Closed
Jason-Sy opened this issue Aug 27, 2019 · 9 comments
Closed
Labels
Component: Framework/Indexer Component: Framework/Mview Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Jason-Sy
Copy link
Member

Jason-Sy commented Aug 27, 2019

This issue is similar to #4470

Preconditions (*)

  1. Magento 2.3.0/1
  2. PHP 7.2

Steps to reproduce (*)

  1. Create a simple module with a vendor name which contains at least one number (ex. Mage2Vendor)
  2. Add a custom indexer to the module just like on the devdocs
<indexer id="mage2module_url_rewrites" view_id="mage2module_url_rewrites" class="Mage2Vendor\Module\Model\Indexer\UrlRewrites">
  <title translate="true">Title.</title>
  <description translate="true">Description.</description>
</indexer>
  1. setup:upgrade

Expected result (*)

  1. Normal Upgrade output & module gets properly installed.

Actual result (*)

  1. Console trows an error at running scheme:
Running schema recurring...The XML in file "/root/app/code/Mage2Vendor/Module/etc/indexer.xml" is invalid:
Element 'indexer', attribute 'class': [facet 'pattern'] The value 'Mage2Vendor\Module\Model\Indexer\UrlRewrites' is not accepted by the pattern '[a-zA-Z\\]+'.
Line: 3

Element 'indexer', attribute 'class': 'Mage2Vendor\Module\Model\Indexer\UrlRewrites' is not a valid value of the atomic type 'classType'.
Line: 3

Note

If you bypass the first issue by editing Magento/Framework/Indexer/etc/indexer.xsd
the same issue happens with the mview.xml file.

Running data recurring...The XML in file "/root/app/code/Mage2Vendor/Module/etc/mview.xml" is invalid:
Element 'view', attribute 'class': [facet 'pattern'] The value 'Mage2Vendor\Module\Model\Indexer\UrlRewrites' is not accepted by the pattern '[a-zA-Z\\]+'.
Line: 3

Element 'view', attribute 'class': 'Mage2Vendor\Module\Model\Indexer\UrlRewrites' is not a valid value of the atomic type 'classType'.
Line: 3
@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2019

Hi @Jason-Sy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Jason-Sy do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @Jason-Sy. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Jason-Sy, here is your Magento instance.
Admin access: https://i-24323-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Jason-Sy
Copy link
Member Author

Jason-Sy commented Aug 27, 2019

Hi @Jason-Sy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Jason-Sy do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

Tested on a vanilla magento 2.3.1 instance

@magento-engcom-team
Copy link
Contributor

Hi @Jason-Sy. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Jason-Sy, here is your Magento instance.
Admin access: https://i-24323-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Jason-Sy added a commit to Jason-Sy/magento2 that referenced this issue Aug 27, 2019
Jason-Sy added a commit to Jason-Sy/magento2 that referenced this issue Aug 27, 2019
Jason-Sy added a commit to Jason-Sy/magento2 that referenced this issue Aug 27, 2019
@ghost ghost assigned Jason-Sy Aug 27, 2019
@rogyar rogyar added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Framework/Indexer Component: Framework/Mview Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 28, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @rogyar
Thank you for verifying the issue. Based on the provided information internal tickets MC-19692 were created

Issue Available: @rogyar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 28, 2019
@ghost ghost unassigned Jason-Sy Sep 27, 2019
@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 23, 2019

Can be closed ad fixed and delivered in #24324

@Ksardarion
Copy link

@magento-engcom-team
The same issue exists for table subscriptions in version 2.3.3
Do I need to create another one here, on the github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Indexer Component: Framework/Mview Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants