Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Mage_Core_Block_Abstract::getHelper #25

Closed
stalniy opened this issue Jun 10, 2012 · 1 comment
Closed

Rename Mage_Core_Block_Abstract::getHelper #25

stalniy opened this issue Jun 10, 2012 · 1 comment

Comments

@stalniy
Copy link

stalniy commented Jun 10, 2012

Mage_Core_Block_Abstract::getHelper should be renamed because it's not intuitively that this method returns a singleton block instance and by other hand Mage_Core_Block_Abstract::helper returns a singleton instance of helper.
@magento-team
Copy link
Contributor

We have revised this method and found, that it is a legacy one with no usage in Magento code. So we have removed it at all and fixed the PHPDoc of Mage_Core_Block_Abstract::helper() method.

You can expect the changes to appear in the next publication.

Thank you for the notice regarding these methods.

magento-team added a commit that referenced this issue Jun 21, 2012
@magento-team
Update as of 6/20/2012
0c3e67e 
* Implemented locale translation inheritance
* Implemented new format for exporting customer data
* Added initial Javascript code for globalization and localization
* Added initial Javascript unit tests
* Implemented file signature for urls of static files - better CDN support
* Implemented optional tracking of changes in view files fallback - cached by default, tracked in developer mode
* Introduced `@magentoDbIsolation` annotation in integration tests - isolates DB modifications made by tests
* Started refactoring of Visual Design Editor Javascript architecture
* Github requests:
  * [#25](#25) Removed unused `Mage_Core_Block_Abstract::getHelper()` method
* Fixed:
  * "$_FILES array is empty" messages in exception log upon installation
  * Long attribute table aliases, that were producing errors at DB with lower identifier limitation than MySQL
  * Watermark opacity function did not work with ImageMagick
  * `Magento_Test_TestCase_ControllerAbstract::assertRedirect` was used in a wrong way
  * Inability to reorder a downloadable product
  * ACL tables aliases interference with other table aliases
* Several tests are made incomplete temporary, appropriate bugs to be fixed in the nearest future
@SunshineTech SunshineTech mentioned this issue Dec 5, 2013
Closed
@drexlma drexlma mentioned this issue Apr 1, 2014
Closed
@drexlma drexlma mentioned this issue Jun 12, 2014
Closed
@leeyisoft leeyisoft mentioned this issue Jun 14, 2014
Closed
This was referenced Nov 22, 2014
Closed
Closed
Closed
@Crustymd Crustymd mentioned this issue Dec 11, 2014
Closed
@sivajik34 sivajik34 mentioned this issue Jan 2, 2015
Closed
magento-team pushed a commit that referenced this issue Jan 16, 2015
@vpelipenko
Merge pull request #25 from magento-firedrakes/bugfixes
94f9665 
[Firedrakes] Bugfixes
@mattisbusycom mattisbusycom mentioned this issue Jan 16, 2015
Closed
@rgauny rgauny mentioned this issue Jan 23, 2015
Closed
@SKovbel SKovbel mentioned this issue Jan 31, 2015
Closed
@madhur99 madhur99 mentioned this issue Feb 22, 2015
Closed
@berliozd berliozd mentioned this issue Feb 27, 2015
Closed
This was referenced Mar 4, 2015
Closed
Closed
@stevieyu stevieyu mentioned this issue Apr 3, 2015
Closed
@sivajik34 sivajik34 mentioned this issue Apr 15, 2015
Closed
@yukoff yukoff mentioned this issue May 4, 2015
Closed
@ghost ghost mentioned this issue May 26, 2015
Closed
@phphphp phphphp mentioned this issue May 29, 2015
Closed
@pccomfrank pccomfrank mentioned this issue Jun 2, 2015
Closed
@flakerimi flakerimi mentioned this issue Jun 23, 2015
Closed
@vinhtrau vinhtrau mentioned this issue Jul 4, 2015
Closed
@elliothagerty elliothagerty mentioned this issue Jul 9, 2015
Closed
@patrickpeng2091 patrickpeng2091 mentioned this issue Jul 12, 2015
Closed
@heqixi heqixi mentioned this issue Jul 19, 2021
Closed
1 task
@chequille chequille mentioned this issue Aug 20, 2021
Closed
5 tasks
@mrlerch mrlerch mentioned this issue Oct 23, 2021
Closed
4 tasks
@markshust markshust mentioned this issue Nov 11, 2021
Closed
4 tasks
@Green2Matter Green2Matter mentioned this issue Jan 20, 2022
Closed
4 tasks
@engcom-November engcom-November mentioned this issue Feb 24, 2022
Open
5 tasks
@engcom-November engcom-November mentioned this issue Mar 8, 2022
Closed
@jorgb90 jorgb90 mentioned this issue Apr 29, 2022
Closed
5 tasks
@benediktblank benediktblank mentioned this issue May 23, 2022
Closed
5 tasks
@pmonosolo pmonosolo mentioned this issue Aug 9, 2022
Closed
5 tasks
@ghost ghost mentioned this issue Aug 10, 2022
Closed
5 tasks
@ghost ghost mentioned this issue Aug 19, 2022
Closed
5 tasks
@mohammedTBB mohammedTBB mentioned this issue Sep 7, 2022
Closed
5 tasks
@mohammedTBB mohammedTBB mentioned this issue Sep 15, 2022
Closed
5 tasks
@quintinnel2 quintinnel2 mentioned this issue Nov 6, 2022
Closed
5 tasks
@pmonosolo pmonosolo mentioned this issue Nov 14, 2022
Closed
5 tasks
@niku0911 niku0911 mentioned this issue Jan 14, 2023
Closed
This was referenced Feb 17, 2023
Open
Closed
@kisfelix kisfelix mentioned this issue Apr 4, 2023
Closed
5 tasks
@yohangwak yohangwak mentioned this issue May 5, 2023
Open
5 tasks
@Hexmage Hexmage mentioned this issue Jul 11, 2023
Closed
5 tasks
@dandrikop dandrikop mentioned this issue Jul 15, 2023
Closed
5 tasks
@KhanBadshah588 KhanBadshah588 mentioned this issue Oct 6, 2023
Closed
5 tasks
Closed
5 tasks
@iranimij iranimij mentioned this issue Nov 21, 2023
Closed
5 tasks
@nabeelfocus nabeelfocus mentioned this issue Jan 3, 2024
Closed
5 tasks
@AndeeKnitsLTD AndeeKnitsLTD mentioned this issue May 1, 2024
Closed
5 tasks
@shakeblue shakeblue mentioned this issue May 31, 2024
Closed
5 tasks
@aurel5542 aurel5542 mentioned this issue Jun 29, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stalniy @magento-team