Numerical placeholder count in Phrase starts with %1, however js code assumes 0%

[vitcra]

Preconditions (*)

1. Magento 2.3.3

Steps to reproduce (*)

1. Check this code: https://github.com/magento/magento2/blob/2.3.3/lib/internal/Magento/Framework/Phrase/Renderer/Placeholder.php#L43

2. Compare to: https://github.com/magento/magento2/blob/2.3.3/app/code/Magento/Ui/view/frontend/web/js/model/messages.js#L52

Expected result (*)

Js version of __('Carrier with such method not found: %1, %2', 'one', 'two') should produce the message of 'Carrier with such method not found: one, two'.

See for example: https://github.com/magento/magento2/blob/2.3.3/app/code/Magento/Checkout/Model/ShippingInformationManagement.php#L198

Actual result (*)

Js version of __('Carrier with such method not found: %1, %2', 'one', 'two') produces the message of 'Carrier with such method not found: two, one'.

[m2-assistant]

Hi @vitcra. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@vitcra do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Issue is reproducible on 2.3-develop.
Modify string to __('Carrier with such method not found: %1, %2', "one test", "two test") in https://github.com/magento/magento2/blob/2.3.3/app/code/Magento/Checkout/Model/ShippingInformationManagement.php#L198

Result:

[magento-engcom-team]

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-22126 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @korostii. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[magento-engcom-team]

Hi @vitcra. Thank you for your report.
The issue has been fixed in #25359 by @korostii in 2.4-develop branch
Related commit(s):

• 2596ca7de56a5175338230a7e54d4e8fda902851
• 2f5909e408ae977435540b260fbabbfa4462a062
• d1b63cbb6b682597b0a725e672f10c1305ac643f
• f08857bbb8950a154e67f71bb83f4a19dc341640
• 71ca4bb2bc4e490cc696849b5a943b186f5caa6b
• d79bf5e53a42020220abc586ef717a4b83470dcd
• 3d36928e0b5043b847c724b771bc863d58ddceef
• 9db06e58b1b93c09c009884b1e2ed54a52fa3df1
• df48d3e69fc17c7b54ddf2e33840da3ca3af2460
• 9ccac04ff5908efd749c42187bc2ab79798f0d6f
• ce191710acfaaf8457d2bb66c192d8d3bb984844

The fix will be available with the upcoming 2.4.0 release.