Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() contains a wrong PHPDoc comment for the $file variable #2558

Closed
dmitrii-fediuk opened this issue Nov 30, 2015 · 2 comments
Closed

\Magento\MediaStorage\Model\File\Storage\Synchronization::synchronize() contains a wrong PHPDoc comment for the $file variable #2558

dmitrii-fediuk opened this issue Nov 30, 2015 · 2 comments
Assignees
@renatocason
Labels
bug report Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@dmitrii-fediuk
Copy link

https://github.com/magento/magento2/blob/2.0.0/app/code/Magento/MediaStorage/Model/File/Storage/Synchronization.php#L59-L60

Should be

/** @var \Magento\Framework\Filesystem\File\WriteInterface $file */
@mazhalai
Copy link
Contributor

Thank you for reporting, we have created ticket MAGETWO-46204 to fix it.

@mazhalai mazhalai added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development PS labels Nov 30, 2015
@vkorotun vkorotun removed the PS label Aug 4, 2016
magento-team pushed a commit that referenced this issue Mar 8, 2017
MAGETWO-65434: [GitHub][PR] Fix issue #2558 #8762
5fdb38c 
 - Merge Pull Request #8762 from renatocason/magento2:hotfix/2558_comment_fix
magento-team added a commit that referenced this issue Mar 8, 2017
@magento-team
MAGETWO-65434: [GitHub][PR] Fix issue #2558 #8762
87469a5
@okorshenko
Copy link
Contributor

@dmitry-fedyuk thank you for reporting the issue
@renatocason thank you for fixing the issue in PR: #8762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renatocason renatocason

Labels
bug report Component: Catalog Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dmitrii-fediuk @mazhalai @wert2all @renatocason @okorshenko @vkorotun