Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixins are not applied for advanced bundled modules #25586

Closed
krzksz opened this issue Nov 13, 2019 · 4 comments
Closed

Mixins are not applied for advanced bundled modules #25586

krzksz opened this issue Nov 13, 2019 · 4 comments
Assignees
Labels
Component: Framework/RequireJs Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@krzksz
Copy link
Contributor

krzksz commented Nov 13, 2019

Preconditions (*)

  1. Bundle your JavaScript files using one advanced bundling technique of your choosing, e.g. https://github.com/magento/baler

Steps to reproduce (*)

  1. Open the shop.
  2. Notice that mixins are neither loaded nor applied for any of the bundled modules.

Expected result (*)

  1. Mixins are properly loaded and applied for all modules.

Actual result (*)

  1. Mixins are neither loaded nor applied.

Please consult magento/baler#23 where I described the root cause of the issue in great detail. I'm submitting a separate issue here because we believe that it would be best to fix it directly in core and I'm going to send a PR in a few minutes 🤗

@m2-assistant
Copy link

m2-assistant bot commented Nov 13, 2019

Hi @krzksz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@krzksz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 13, 2019
@ghost ghost assigned krzksz Nov 13, 2019
@drpayyne drpayyne self-assigned this Nov 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2019

Hi @drpayyne. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@drpayyne drpayyne added Component: Framework/RequireJs Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 15, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 15, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 15, 2019

@drpayyne Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@ghost ghost unassigned drpayyne Nov 15, 2019
@drpayyne drpayyne added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 15, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @drpayyne
Thank you for verifying the issue. Based on the provided information internal tickets MC-23196 were created

Issue Available: @drpayyne, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 15, 2019
@drpayyne drpayyne added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Nov 15, 2019
krzksz pushed a commit to krzksz/magento2 that referenced this issue Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/RequireJs Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants