Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health_check.php fails if any database cache engine configured #25669

Closed
ilnytskyi opened this issue Nov 20, 2019 · 6 comments
Closed

health_check.php fails if any database cache engine configured #25669

ilnytskyi opened this issue Nov 20, 2019 · 6 comments
Assignees
Labels
Component: Cache Event: cdkharkiv19nov Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ilnytskyi
Copy link
Contributor

ilnytskyi commented Nov 20, 2019

Preconditions (*)

  1. Configure any cache to database in env.php
    2.3-develop
    'cache' => [
        'frontend' => [
            '{some_frontend_cache}' => [
                'backend' => 'database',
                'backend_options' => [],
                'id_prefix' => 'U_'
            ]
        ],
        'type' => [
            '{any_cache_type_here}' => [
                'frontend' => '{some_frontend_cache}'
            ]
        ]
    ]

Steps to reproduce (*)

  1. configure any cache type to database

Expected result (*)

  1. health_check.php works

Actual result (*)

  1. health_check.php fails since can't find database class in
$backend = new $cacheBackendClass($cacheConfig[ConfigOptionsListConstants::CONFIG_PATH_BACKEND_OPTIONS]);
  1. health_check.php fails since can't create instance of \Magento\Framework\Cache\Backend\Database and throws expeditions from here
    \Magento\Framework\Cache\Backend\Database::__construct
'Option "adapter" should be declared and extend \Magento\Framework\DB\Adapter\AdapterInterface!'
Option "data_table" or "data_table_callback" should be declared!
Option "tags_table" or "tags_table_callback" should be declared!
'DB Adapter should be declared and extend \Magento\Framework\DB\Adapter\AdapterInterface'

however the cache works just uses default connection
Selection_210

@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @ilnytskyi. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ilnytskyi do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 20, 2019
@ilnytskyi ilnytskyi added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Nov 20, 2019
@engcom-Echo engcom-Echo self-assigned this Nov 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Echo engcom-Echo added Component: Cache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 20, 2019
@ghost ghost unassigned engcom-Echo Nov 20, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 20, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Echo
Thank you for verifying the issue. Based on the provided information internal tickets MC-29016 were created

Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@andrewbess andrewbess self-assigned this Nov 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 23, 2019

Hi @andrewbess. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


andrewbess pushed a commit to andrewbess/magento2ce that referenced this issue Nov 24, 2019
…nfigured

- fixed wrong "@return description" of the remove method in class
  Magento\Framework\Cache\Backend\Database
- fixed wrong returned type of the method "unlock" in class
  Magento\Framework\Lock\Backend\Cache
- fixed health_check to create instances into block "check cache storage
  availability"
@andrewbess
Copy link

#cdkharkiv19nov

andrewbess pushed a commit to andrewbess/magento2ce that referenced this issue Nov 25, 2019
…nfigured

- fixed PHPDocs according to requirements static tests for CE
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ilnytskyi. Thank you for your report.
The issue has been fixed in #25722 by @andrewbess in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Mar 15, 2020
…ase cache engine configured' #25722

 - Merge Pull Request #25722 from andrewbess/magento2:issue-25669
 - Merged commits:
   1. 5c121e2
   2. 3905038
   3. e59ee3a
   4. 6633cc2
magento-engcom-team pushed a commit that referenced this issue Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cache Event: cdkharkiv19nov Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants