Customer got an error about Virtual Product after setting the shipping address on Cart that contains Downloadable Product only

[TomashKhamlai]

Preconditions (*)

1. No preconditions

Steps to reproduce (*)

1. Create a cart with a downloadable product and try to set the shipping address

Expected result (*)

1. A proper message

Actual result (*)

1. Message about Virtual Product

{
  "errors": [
    {
      "message": "The Cart includes virtual product(s) only, so a shipping address is not used.",
      "category": "graphql-no-such-entity",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "setShippingAddressesOnCart"
      ]
    }
  ],
  "data": {
    "setShippingAddressesOnCart": null
  }
}

[pmclain]

The error message originates in Magento_Quote

https://github.com/magento/graphql-ce/blob/6f81c9d5c63b136ce293e2ee84f262201c5b488d/app/code/Magento/Quote/Model/ShippingAddressManagement.php#L90-L92

This exception is caught in Magento_QuoteGraphQl and re-thrown passing the message in the response.

https://github.com/magento/graphql-ce/blob/e02dc94e04228901706936c2cac778679d5dc346/app/code/Magento/QuoteGraphQl/Model/Cart/AssignShippingAddressToCart.php#L51-L52

There are two reasons a NoSuchEntityException would be thrown:

1. The quote is virtual (no item requiring shipment)
2. The quote does not exist

I would like to change the exception message to something similar to Shipping address is not allowed on cart: cart contains no items for shipment.. Changing the string would be a BiC change and would need to wait for 2.4.

@lenaorobei Is there an alternative I'm overlooking?

[m2-assistant]

Hi @TomashKhamlai. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@TomashKhamlai do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[magento-engcom-team]

✅ Confirmed by @lenaorobei
Thank you for verifying the issue. Based on the provided information internal tickets MC-29905 were created

Issue Available: @lenaorobei, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @sanjay-wagento. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[sanjay-wagento]

#MM20IN

[sanjay-wagento]

@lenaorobei I have reviewed the issue and it seems this is not related to graphql only. The message is comming from Magento core module. It seems above message is not related to virtula product only but it is for all product that does not contain shipping address.

If you think this is valid issue then can you please tell me which type of mesage you want to display through out system for downloadable, virtual and gift card virtula type products?

[lenaorobei]

Hi @sanjay-wagento! Please have a look at the comment from @pmclain. This is the best option we have now - change the exception message.

[magento-engcom-team]

Hi @TomashKhamlai. Thank you for your report.
The issue has been fixed in #28904 by @michalderlatka in 2.4-develop branch
Related commit(s):

• 1091a3089a0cf0c4fec43998dc1b9d82101b720b
• c8c4e06b23a41beb24c347829b41b623c14b70db
• 77bd6138370b66f733c6b51e1d0d62422402dd12

The fix will be available with the upcoming 2.4.1 release.