Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If an exception is occured during a model saving then the model is questionable left in the serialized state (_serializeFields is called, but unserializeFields is not called) #2620

Closed
dmitrii-fediuk opened this issue Dec 6, 2015 · 3 comments
Closed

If an exception is occured during a model saving then the model is questionable left in the serialized state (_serializeFields is called, but unserializeFields is not called) #2620

dmitrii-fediuk opened this issue Dec 6, 2015 · 3 comments
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@dmitrii-fediuk
Copy link

https://mage2.pro/t/283
@dmitrii-fediuk dmitrii-fediuk changed the title If an exception is occured during a model saving then the model is questionable leaved in the serialized state (_serializeFields is called, but unserializeFields is not called) If an exception is occured during a model saving then the model is questionable left in the serialized state (_serializeFields is called, but unserializeFields is not called) Dec 7, 2015
@shiftedreality
Copy link
Member

Hi, @dfediuk

Thanks you for reporting. Created internal ticket MAGETWO-47887 for investigating

@victorgugo victorgugo added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 13, 2016
@dsikkema-magento
Copy link
Contributor

@dfediuk object in memory will be left in serialized state, exception will be caught and re-thrown, and persistent storage will not be corrupted. Is that correct? Can you elaborate on the harm from not calling unserializeFields?

@dsikkema-magento
Copy link
Contributor

Closing for now, please re-open if you find any reasons why the current approach is unsafe.

magento-engcom-team pushed a commit that referenced this issue May 31, 2018
@arhiopterecs
Merge pull request #2620 from magento-thunder/MAGETWO-92154
1ce8c0a 
Fixed issues:
- MAGETWO-92154: [Backport to 2.2] Unlock Locales Editing when SCD on Demand Mode is Enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dmitrii-fediuk @vkholoshenko @victorgugo @shiftedreality @dsikkema-magento