Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing store_name in GraphQl Resolver #27952

Closed
sunel opened this issue Apr 23, 2020 · 4 comments · Fixed by #28855
Closed

Missing store_name in GraphQl Resolver #27952

sunel opened this issue Apr 23, 2020 · 4 comments · Fixed by #28855
Assignees
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed PAP Partners acceleration program Project: GraphQL
Milestone

Comments

@sunel
Copy link

sunel commented Apr 23, 2020

Preconditions (*)

  1. Magento 2.3.4

Steps to reproduce (*)

  1. Request for store_name in storeConfig Query

Expected result (*)

  1. Return store name
{
  "data":{
       "storeConfig":{
               "root_category_id":2,
               "store_name": "Magento"
        }
}

Actual result (*)

{
  "data":{
       "storeConfig":{
               "root_category_id":2,
               "store_name": null
        }
}

As Mentioned in schema 'store_name' can be queried

store_name : String @doc(description: "Name of the store")

But in StoreConfigDataProvider.php its not resolved

private function getBaseConfigData(StoreInterface $store) : array
{
$storeConfig = current($this->storeConfigManager->getStoreConfigs([$store->getCode()]));
$storeConfigData = [
'id' => $storeConfig->getId(),
'code' => $storeConfig->getCode(),
'website_id' => $storeConfig->getWebsiteId(),
'locale' => $storeConfig->getLocale(),
'base_currency_code' => $storeConfig->getBaseCurrencyCode(),
'default_display_currency_code' => $storeConfig->getDefaultDisplayCurrencyCode(),
'timezone' => $storeConfig->getTimezone(),
'weight_unit' => $storeConfig->getWeightUnit(),
'base_url' => $storeConfig->getBaseUrl(),
'base_link_url' => $storeConfig->getBaseLinkUrl(),
'base_static_url' => $storeConfig->getSecureBaseStaticUrl(),
'base_media_url' => $storeConfig->getBaseMediaUrl(),
'secure_base_url' => $storeConfig->getSecureBaseUrl(),
'secure_base_link_url' => $storeConfig->getSecureBaseLinkUrl(),
'secure_base_static_url' => $storeConfig->getSecureBaseStaticUrl(),
'secure_base_media_url' => $storeConfig->getSecureBaseMediaUrl()
];
return $storeConfigData;
}

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2020

Hi @sunel. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@sunel do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 23, 2020
@yogeshkarodiya
Copy link

I am working on this issue

@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2020

Hi @danielrenaud. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2020

Hi @sasha19957099. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 24, 2020
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 24, 2020
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 24, 2020
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jun 24, 2020
@cpartica cpartica added the PAP Partners acceleration program label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed PAP Partners acceleration program Project: GraphQL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants