Added theme is not registered during production mode #2797

moleman · 2015-12-23T11:20:12Z

It seems that added / installed themes are not registered if they are added to a site which is already installed and is set to production mode. By registered I mean that they are not added to the theme table.

After looking at the code it seems that themes are registered differently depending on mode.

In developer mode:

Registered at https://github.com/magento/magento2/blob/develop/app/code/Magento/Theme/Model/Theme/Plugin/Registration.php#L74 which means that the installed theme will be registered correctly during development (or all modes except production).

In production mode:

Registered in observer, https://github.com/magento/magento2/blob/develop/app/code/Magento/Theme/Observer/ThemeRegistrationObserver.php#L47. The event is fired in the installation script of magento/module-theme, https://github.com/magento/magento2/blob/develop/app/code/Magento/Theme/Setup/InstallData.php#L54 which means that it will only register themes during the initial installation of the site and not during upgrades.

This means that if you have a running site in production mode and you decide to install a new theme it will not be registered in the theme table which means that it will not be selectable in the admin.

Steps to reproduce:

Install Magento2, run the installation wizard
Set deploy mode to production, php bin/magento deploy:mode:set production
Add a theme with: composer require
Run php bin/magento setup:upgrade

Expected result:

The installed theme should be registered in the theme table.

Actual result:

The installed theme is not registered in the theme table.

slavvka · 2015-12-23T13:03:14Z

Hi @moleman. Thank you for your inquiry but it is not a bug. Such actions like updating code, adding themes etc aren't supposed to be performed on production since they may lead to unpredictable and unstable site work. Usually such changes should be done not in production mode on some staging server and lately published on production.

moleman · 2015-12-23T13:42:19Z

@slavvka Yes, and that is what we do. We have a build server that builds the sites cleanly with Composer and this is where the new code is introduced. These build artifacts are then deployed to staging and production servers and we then run setup:upgrade to upgrade the database in production after the deployment of the code is done.

So, whats the correct workflow then when you want to add a new theme to a production site so that the theme gets registered in the theme database table? Because currently if we add a new theme it never gets registered because of the issue above.

davidalger · 2015-12-23T15:33:50Z

@slavvka This may not sound like a bug at first read, but the OP isn't talking about developing on a production site, but rather a deployment procedure. There are CLI commands to enable/disable modules, and to "uninstall" a theme, but none to install/activate/register a theme. Builds must be pushed to production in some fashion, and then setup:upgrade run to execute install scripts, and new components moving to production as part of a build need to be registered somehow, whether that is automatic when setup:upgrade is done (as would be expected) or at minimum via a CLI command to register them with the system so it knows about them.

If there is an existing mechanism in the system to roll non-module components out to production and register them without re-installing the software from scratch, it would be great if you could make note of what that is. If there isn't a way to do this, then it is a bug and needs to be solved.

davefarthing · 2016-01-15T19:18:54Z

I have the same experience. Similarly we are not attempting to install a theme directly to production, rather we are installing/creating a theme in dev. then much like @moleman, we use composer to generate a fresh code instance on a clean server before deploying the updated code to the production environment. The successful deployment then triggers 'setup:upgrade' to be run on the production servers in order to run the module updates and schema upgrades. _(I see no other sensible way of performing data-install and updates on the production DB...)_

None of this process adds a new theme record to the 'theme' table so not sure how this is supposed to be achieved.... set the site to developer mode to allow the theme to register... surely not!

I too am interested in what approach is therefore recommended be to update the theme records (and other schema / record changes) in a production environment if this is by "design".

Surely this is a bug that needs fixing.....

mazhalai · 2016-01-15T20:51:26Z

Thank you all for your input, we have created MAGETWO-47999 to fix it.

mazhalai · 2016-03-08T21:39:09Z

@moleman thank you for reporting. We have merged a fix in the develop branch, hence closing this ticket. Please create a new ticket if issues still arise.

davidalger · 2016-03-28T17:31:51Z

@mazhalai Could you comment on what the ultimate fix was/is? I'm not seeing commits tagged with this GH issue id, and it's unclear from the thread if this was being fixed by having setup:upgrade add the theme or via some other means.

mazhalai · 2016-03-28T17:40:27Z

@davidalger too many commits, maybe it is easier to post the files modified/introduced: (you can look in blame/history of each file for specific commits)

https://github.com/magento/magento2/blob/develop/app/code/Magento/Theme/Model/Theme/Registration.php
https://github.com/magento/magento2/blob/develop/app/code/Magento/Theme/Setup/InstallData.php
https://github.com/magento/magento2/blob/develop/app/code/Magento/Theme/Setup/RecurringData.php
https://github.com/magento/magento2/blob/develop/setup/src/Magento/Setup/Model/Installer.php

and related tests. We also removed an obsolete event and related observer

davidalger · 2016-03-28T20:18:04Z

Based on commit 0132caf it looks like they should now be auto-registered when setup:upgrade is run. Thanks @mazhalai!

woei66 · 2016-03-29T04:42:35Z

@mazhalai

How do I know that the patch will be available for production if I install magento2 by below command:
composer create-project --repository-url=https://repo.magento.com/ magento/project-community-edition magento2

thank you.

Igloczek · 2016-04-08T14:53:14Z

@mazhalai @slavvka @davidalger @alankent
Could you provide some "estimated release version" info marking issue as resolved by your internal ticket ID, to let us know when it should be released?

I spend a lot of time trying to figure out if that fix was released or not and still have no idea...
Official release notes also don't contains any info about resolved github/internal issues, so how we can know what was fixed?

mazhalai · 2016-04-08T15:08:13Z

@Igloczek the fix is in the develop branch, but it hasn't been added to a release yet.

The way to tell if a fix is in a release version:

Open a file on Github and click "blame", for example in this case see https://github.com/magento/magento2/blame/develop/app/code/Magento/Theme/Model/Theme/Registration.php
Look for the ticket number on the left hand side: MAGETWO-47999
Now click on "Normal view" button
Change the dropdown on left, below "code": branch from "develop" to tags-> 2.0.4 or any other release version
Click blame and look for ticket number. If you dont find the fix there, then it wasn't included in the release.

Igloczek · 2016-04-08T15:29:58Z

Don't you think this is a ridiculous "solution" for tracking issues status?

mazhalai · 2016-04-08T16:20:34Z

@Igloczek sorry we cannot share access to our internal tracking.

Igloczek · 2016-04-08T16:29:07Z

How about Github milestones and referencing Github issues in commit messages?

heldchen · 2016-04-08T16:29:16Z

@mazhalai can you at least shed some light on when the patch might make it into an official release? according to this ticket this bug was fixed mid january - since then 4 release versions happened...

mazhalai · 2016-04-08T16:36:51Z

@Igloczek yes I apologize for the Github issue in the commit message, but we do not track Github milestones in tickets.

@heldchen It was fixed in mid Feb and contributed in Mar, not Jan. @elenleonova any comment on next patch release date?

peec · 2016-04-27T20:19:42Z

Finally found this issue! So basically right now custom themes does not register. I did not understand why my theme did not appear, but this explains everything.

woei66 · 2016-04-28T02:54:58Z

hi, @mazhalai
Is the bug fixed in 2.0.4 version?
I had upgrade my magent2 to 2.0.4 but I still can't register my customized theme.
Any suggestion to verify step by step?
thank you.

peec · 2016-04-28T11:11:04Z

@woei66 No this is not added in 2.0.X yet ( It's just in develop branch ) and not 2.0:

2.X branch: https://github.com/magento/magento2/blame/2.0/app/code/Magento/Theme/Model/Theme/Registration.php

vs

Develop: https://github.com/magento/magento2/blame/develop/app/code/Magento/Theme/Model/Theme/Registration.php

Search for MAGETWO-47999

on both of those links, you see that the fix is only in develop branch!

This fix is urgent. Please add to 2.0.5!

Igloczek · 2016-04-29T08:15:22Z

@benmarks @maksek
That's what I'm talking about on Developers Paradise - we have closed issue, resolved by some of your internal ticket (without referencing github issue in commit msg) and merged into develop - AFAIK it should be available in next release.
But... two months and two releases later - still not available, no one knows when it should be added to stable version 😥

vduglued · 2016-05-02T10:24:27Z

What's the proper/recommended fix until this goes into a prod. release? Switch production to developer mode, run upgrade, and switch back?

EDIT: my dev env is in "developer" mode and the theme files are all present. Running upgrade doesn't register the theme either.

Igloczek · 2016-05-02T10:47:23Z

I fix it on production using SQL query to manually add record to theme table.

vduglued · 2016-05-02T12:17:16Z

Thanks @Igloczek - the direct SQL insert seems like the quick option.

peec · 2016-05-04T08:08:46Z

Not fixed in 2.0.5 either.

THE PROBLEM

=== frontend -> Magento/luma -> nb_NO ===
.................................................................................................................................................................................................................
Successful: 2038 files; errors: 0
---

=== frontend -> MyVendor/Base -> nb_NO ===
Unable to load theme by specified key: 'MyVendor/Base'>

NOW LETS SEE:

mysql> select * from theme;
+----------+-----------+-----------------+-------------------+----------------------------------+-------------+-----------+------+-----------------+
| theme_id | parent_id | theme_path      | theme_title       | preview_image                    | is_featured | area      | type | code            |
+----------+-----------+-----------------+-------------------+----------------------------------+-------------+-----------+------+-----------------+
|        1 |      NULL | Magento/blank   | Magento Blank     | preview_image_5710e776daadc.jpeg |           0 | frontend  |    0 | Magento/blank   |
|        2 |         1 | Magento/luma    | Magento Luma      | preview_image_5710e776ee428.jpeg |           0 | frontend  |    0 | Magento/luma    |
|        3 |      NULL | Magento/backend | Magento 2 backend | NULL                             |           0 | adminhtml |    0 | Magento/backend |
+----------+-----------+-----------------+-------------------+----------------------------------+-------------+-----------+------+-----------------+

3 rows in set (0,06 sec)

TEMPORARY SOLUTION:

mysql> insert into theme (parent_id,theme_path,theme_title,preview_image,is_featured,area,type,code) \
       VALUES ('1','MyVendor/Base','MyVendor Base', NULL, 0, 'frontend', 0, 'MyVendor/Base');

maksek · 2016-05-10T20:04:45Z

@peec all fixes from github are targeting 2.1 release, you won't see them in patch releases yet. For this particular i got confirmation - will be targeting 2.0.7

hectornguyen · 2016-05-29T06:55:44Z

I'm using Magento 2.0.7 at this moment, and seem it still not be patched yet.

ClaudiuCreanga · 2016-07-11T12:58:59Z

Can someone update the documentation and explain what are virtual and staging theme types and when to use them? Can't find anything about it. Thanks!

ihor-sviziev · 2016-08-25T09:55:40Z

@maksek @mazhalai this fix was reverted in c4e5f32 and this issue still exists.

Could you re-open it and fix?

erikhansen · 2016-11-15T05:00:45Z

@maksek @mazhalai I'm still seeing this issue on 2.1.2 as well. Is there a new ticket open that covers this issue?

gil-- · 2016-12-09T23:04:24Z

@erikhansen agreed. Just ran into this and followed @peec mysql code to resolve it.

jpratt · 2016-12-17T04:01:11Z

Anyway around this in production mode, using 2.1.0? I tried adding it directly in the theme table and appears to be successful, however then get an error saving products 'Required Parameter theme_dir was not passed'. If I remove the theme I entered manually in the table the error goes away when saving products. @gil-- have you tested saving products after adding the row manually?

Igloczek · 2016-12-17T11:37:46Z

@jpratt are you 100% sure that theme_dir was correct?
Solution with manual adding them via SQL query is 100% correct and works well for us and as you can see by votes, many other ppl.

avra911 · 2017-03-08T16:06:27Z

@Igloczek running setup:upgrade doesn't detect and add the new design into the theme table as well?

When I tried it, I only notices is adding 1 instead of 0 in TYPE column.

leoquijano · 2018-03-07T15:47:15Z

I'm having this problem in v2.2.3 as well. This is causes problems when testing new themes in integration/staging websites, which are usually set to production mode to mimic the live site as closely as possible.

My workaround for that is to switch to developer mode, load the admin (so the row in the theme table gets created), and then switch back to production mode. This is in case someone would like to avoid manual updates to the DB.

The fix should really be formally included in releases before closing the Github issue. No integrator would use the develop branch when working with actual websites.

slackerzz · 2018-07-18T07:42:50Z

This bug is still present in 2.2.5.
@magento-engcom-team maybe this issue should be reopened

penglongyun · 2018-09-04T10:36:20Z

This bug is still present, I add a custom adminhtml theme,but not working in developer mode

Igloczek · 2018-09-04T10:52:24Z

@penglongyun admin themes work differently, your problem it's probably not related to this issue.
Check the docs for details:

OvalMedia · 2022-06-22T09:48:10Z

2.4.3-p1 And still not fixed.
The idea behind it is not based on real world problems. In my case I created a new subtheme that would be used in a new feature. This theme was supposed to be scheduled automatically. I relied on my deployment script to take care of installing the new theme and just by chance i saw it wasn't there. The automatic scheduling would have hit a brick wall.

But I assume since this issue is closed nobody will care...

slackerzz · 2022-06-22T12:29:55Z

@OvalMedia while this is issue is not fixed you can now dump your themes in app/etc/config.php to be sure that the themes are registered, e.g.:

<?php
return [
    'modules' => [...],
    'themes' => [
        'frontend/Magento/blank' => [
            'parent_id' => null,
            'theme_path' => 'Magento/blank',
            'theme_title' => 'Magento Blank',
            'is_featured' => '0',
            'area' => 'frontend',
            'type' => '0',
            'code' => 'Magento/blank'
        ],
        'adminhtml/Magento/backend' => [
            'parent_id' => null,
            'theme_path' => 'Magento/backend',
            'theme_title' => 'Magento 2 backend',
            'is_featured' => '0',
            'area' => 'adminhtml',
            'type' => '0',
            'code' => 'Magento/backend'
        ],
        'frontend/Magento/luma' => [
            'parent_id' => 'Magento/blank',
            'theme_path' => 'Magento/luma',
            'theme_title' => 'Magento Luma',
            'is_featured' => '0',
            'area' => 'frontend',
            'type' => '0',
            'code' => 'Magento/luma'
        ],
        'frontend/MyVendor/MyTheme => [
            'parent_id' => 'Magento/luma',
            'theme_path' => 'MyVendor/MyTheme',
            'theme_title' => 'MyVendor MyTheme',
            'is_featured' => '0',
            'area' => 'frontend',
            'type' => '0',
            'code' => 'MyVendor/MyTheme'
        ]
    ],

slavvka added the CS label Dec 23, 2015

slavvka self-assigned this Dec 23, 2015

slavvka closed this as completed Dec 23, 2015

davidalger reopened this Dec 23, 2015

mazhalai added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 15, 2016

MomotenkoNatalia added PS and removed CS labels Jan 19, 2016

MomotenkoNatalia unassigned slavvka Jan 19, 2016

mazhalai mentioned this issue Feb 1, 2016

Theme not registering with Varnish/Nginx setup #3225

Closed

serzhik mentioned this issue Feb 16, 2016

Can't add custom theme #3409

Closed

mazhalai closed this as completed Mar 8, 2016

mazhalai mentioned this issue Mar 28, 2016

Installing a custom theme throws frontend error #3877

Closed

mazhalai mentioned this issue May 10, 2016

Magento unable to fully read themes [Magento 2.0.5] #4445

Closed

coop-ci mentioned this issue Nov 4, 2016

Zero downtime on non-upgrade deployments davidalger/capistrano-magento2#34

Closed

erikhansen mentioned this issue Nov 15, 2016

Deployment continues even when setup:static-content:deploy contains exception davidalger/capistrano-magento2#44

Closed

erikhansen mentioned this issue Mar 8, 2017

Deploying a new theme fails davidalger/capistrano-magento2#63

Closed

lancergr mentioned this issue Sep 13, 2017

hpp icon and editor wysiwyg doesn't work Adyen/adyen-magento2#186

Closed

davidalger mentioned this issue Feb 7, 2018

Run setup:upgrade before compile assets davidalger/capistrano-magento2#95

Closed

Added theme is not registered during production mode #2797

Added theme is not registered during production mode #2797

Comments

moleman commented Dec 23, 2015

Steps to reproduce:

Expected result:

Actual result:

slavvka commented Dec 23, 2015

moleman commented Dec 23, 2015

davidalger commented Dec 23, 2015

davefarthing commented Jan 15, 2016

mazhalai commented Jan 15, 2016

mazhalai commented Mar 8, 2016

davidalger commented Mar 28, 2016

mazhalai commented Mar 28, 2016

davidalger commented Mar 28, 2016

woei66 commented Mar 29, 2016

Igloczek commented Apr 8, 2016

mazhalai commented Apr 8, 2016

Igloczek commented Apr 8, 2016

mazhalai commented Apr 8, 2016

Igloczek commented Apr 8, 2016

heldchen commented Apr 8, 2016

mazhalai commented Apr 8, 2016

peec commented Apr 27, 2016

woei66 commented Apr 28, 2016

peec commented Apr 28, 2016

Igloczek commented Apr 29, 2016

vduglued commented May 2, 2016 • edited Loading

Igloczek commented May 2, 2016 • edited Loading

vduglued commented May 2, 2016

peec commented May 4, 2016

THE PROBLEM

NOW LETS SEE:

TEMPORARY SOLUTION:

maksek commented May 10, 2016 • edited Loading

hectornguyen commented May 29, 2016

ClaudiuCreanga commented Jul 11, 2016

ihor-sviziev commented Aug 25, 2016 • edited Loading

erikhansen commented Nov 15, 2016

gil-- commented Dec 9, 2016

jpratt commented Dec 17, 2016

Igloczek commented Dec 17, 2016 • edited Loading

avra911 commented Mar 8, 2017 • edited Loading

leoquijano commented Mar 7, 2018

slackerzz commented Jul 18, 2018

penglongyun commented Sep 4, 2018

Igloczek commented Sep 4, 2018 • edited Loading

OvalMedia commented Jun 22, 2022

slackerzz commented Jun 22, 2022

vduglued commented May 2, 2016 •

edited

Loading

Igloczek commented May 2, 2016 •

edited

Loading

maksek commented May 10, 2016 •

edited

Loading

ihor-sviziev commented Aug 25, 2016 •

edited

Loading

Igloczek commented Dec 17, 2016 •

edited

Loading

avra911 commented Mar 8, 2017 •

edited

Loading

Igloczek commented Sep 4, 2018 •

edited

Loading