Skip to content

Elasticsearch attribute filter with pagination issue #27989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santosh-gaggle opened this issue Apr 25, 2020 · 10 comments · Fixed by #28015
Closed

Elasticsearch attribute filter with pagination issue #27989

santosh-gaggle opened this issue Apr 25, 2020 · 10 comments · Fixed by #28015
Labels
Component: Catalog Component: Elasticsearch Component: Filter Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@santosh-gaggle
Copy link

santosh-gaggle commented Apr 25, 2020

Elasticsearch attribute filter with pagination issue

Preconditions (*)

  1. Magento 2.4-develop;
  2. Sample Data;
  3. Elasticsearch 6 +

Steps to reproduce:

  1. Go to Storefront;
  2. Go to Men->Tops->Hoodies & Sweatshirts category (for example);
  3. Go to the second 2 page;
  4. On filter panel choose black from Color (for example);

Actual result:

✖️ After applying the filter, the products are not displayed

Peek 2020-04-30 14-42

  1. ✔️ When deleting p=2 from URL path, products are displayed

Peek 2020-04-30 14-51

Expected result:

  1. it should show the filtered products.
  2. if I am on the 2th page and filtered any attribute then it should remove the pagination value from the URL or it should be managed with the product item count
  3. after removing the pagination value from the URL it's showing the 6 number of products
@m2-assistant
Copy link

m2-assistant bot commented Apr 25, 2020

Hi @santosh-gaggle. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@santosh-gaggle do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 25, 2020
@santosh-gaggle
Copy link
Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @santosh-gaggle. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@engcom-Alfa engcom-Alfa self-assigned this Apr 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2020

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Apr 30, 2020

The issue is reproducible on fresh 2.4-develop

Preconditions:

Sample Data;
Elasticsearch 6+;

Steps to Reproduce:

  1. Go to Storefront;
  2. Go to Men->Tops->Hoodies & Sweatshirts category (for example);
  3. Go to the second 2 page;
  4. On filter panel choose black from Color (for example);

Actual result:

✖️ After applying the filter, the products are not displayed

Peek 2020-04-30 14-42

  1. ✔️ When deleting p=2 from URL path, products are displayed

Peek 2020-04-30 14-51

@engcom-Alfa engcom-Alfa added Component: Elasticsearch Component: Catalog Component: Filter Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 30, 2020
@ghost ghost unassigned engcom-Alfa Apr 30, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 30, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-33873 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@kaktusAtAdvox
Copy link

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2020

Hi @kaktusAtAdvox! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@kaktusAtAdvox
Copy link

@magento I am working on this

@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 16, 2021
@magento-engcom-team
Copy link
Contributor

Hi @santosh-gaggle.

Thank you for your report and collaboration!

The related internal Jira ticket MC-33873 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Component: Elasticsearch Component: Filter Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
5 participants