Skip to content

Added null page attribute value to url generate parameters #28505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kaktusAtAdvox
Copy link

Description (*)

Query parameters passed to buildUrl() method were missing page attribute, which should be set to null in order to reset page value.

Fixed Issues (if relevant)

  1. Fixes Elasticsearch attribute filter with pagination issue #27989

Manual testing scenarios (*)

  1. Go to Storefront;
  2. Go to Men->Tops->Hoodies & Sweatshirts category (for example);
  3. Go to the second 2 page;
  4. On filter panel choose black from Color (for example);

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2020

Hi @kaktusAtAdvox. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@kaktusAtAdvox
Copy link
Author

This issue is already solved in #28015

@m2-assistant
Copy link

m2-assistant bot commented Jun 4, 2020

Hi @kaktusAtAdvox, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kaktusAtAdvox kaktusAtAdvox deleted the 27989-attribute-filter-with-pagination-issue branch June 4, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch attribute filter with pagination issue
2 participants