typo: setup:config:set --session-save-redis-sentinel-connect-retires (instead of retries)

[medigeek]

Preconditions (*)

1. 2.3.5-p1
2. 2.4-develop -- in git: https://github.com/magento/magento2/blob/2.4-develop/setup/src/Magento/Setup/Model/ConfigOptionsList/Session.php#L43

const INPUT_KEY_SESSION_REDIS_SENTINEL_CONNECT_RETRIES = 'session-save-redis-sentinel-connect-retires';

Steps to reproduce (*)

$ php bin/magento --help setup:config:set | grep retires
      --session-save-redis-sentinel-connect-retires=SESSION-SAVE-REDIS-SENTINEL-CONNECT-RETIRES  Redis Sentinel connect retries.

Expected result (*)

the command parameter ought to be named "retries" instead of "retires"

Actual result (*)

$ php bin/magento --help setup:config:set | grep retires
      --session-save-redis-sentinel-connect-retires=SESSION-SAVE-REDIS-SENTINEL-CONNECT-RETIRES  Redis Sentinel connect retries.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Note:

Not 100% sure if it hinders or not the functionality. Didn't test that, on a first glance in the code, I suppose -retires="..." works as expected.

The default sentinel_connect_retries seems to be set correctly and the constant CONFIG_PATH_SESSION_REDIS_SENTINEL_CONNECT_RETRIES is correct (without the typo): https://github.com/magento/magento2/blob/2.4-develop/setup/src/Magento/Setup/Model/ConfigOptionsList/Session.php#L67

[m2-assistant]

Hi @medigeek. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-35642 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[magento-engcom-team]

Hi @medigeek. Thank you for your report.
The issue has been fixed in #28816 by @medigeek in 2.4-develop branch
Related commit(s):

• 2dfa2218604b370840935e65e982eac02f8afa68

The fix will be available with the upcoming 2.4.2 release.