Payment config settings not decrypted when used?

[cscd98]

In my system.xml:

<field id="production_secret" translate="label" type="obscure" sortOrder="5" showInDefault="1" showInWebsite="1" showInStore="1">
                    <label>Production Secret</label>
                    <backend_model>Magento\Config\Model\Config\Backend\Encrypted</backend_model>
                    <depends><field id='is_sandbox_mode'>0</field></depends>
                </field>

In my payment class which extends \Magento\Payment\Model\Method\Cc

$this->secret = $this->getConfigData('production_secret');

$this->secret is still encrypted? it should be a plain text value

I'm using PHP 7.0.2

Inchoo/magento2-Inchoo_Stripe#6

[rhoerr]

I'm experiencing this as well. The value decrypts fine on the config settings page somehow, but not if I call getConfigData(...) (even elsewhere on the same page request). Magento 2.0.1, PHP 7.0.2.

e: It's not to do with 2.0.1. I can reproduce it on a PHP 7 environment running 2.0.1, but not on a 5.6 environment running 2.0.1. May or may not be PHP.

[alena-marchenko]

created internal ticket MAGETWO-48387

[dsikkema-magento]

If I understand correctly, yes, there is some issue with PHP 7 and encrypted configuration. But in this particular case, I believe the value that's loaded from config is supposed to by encrypted. After it's loaded, using something like the method getConfigData you mentioned, it will need to be decrypted by the code that's requesting the data, using \Magento\Framework\Encryption\EncryptorInterface.

When I do something like your example in php 5.6, I get encrypted text, but when I decrypt it, I get the plain text. The reason it shows up as plaintext on the configuration page is that the backend model, which is responsible for augmenting the save/load behaviors of config fields, decrypts it in that particular situation (but not in all cases where the config is loaded).

Does that sound right?

[rhoerr]

@dsikkema I don't think that's entirely correct. Normally the backend model runs seamlessly somewhere in the process, such that getConfigData from a payment model returns the unencrypted value in and of itself.

It has always worked in this fashion for me, on 1.x and 2.x, except for on one environment running PHP7 as noted earlier. I'm not sure the exact nature of it, but clearly there's some discrepancy at play.

[OnTapKristjan]

Possibly related to issue reported on #3054 as well.

[dsikkema-magento]

We have made some changes which should resolve this for now, can you guys confirm it works as expected on PHP7?

[cscd98]

@dsikkema I can't as I'm using your composer release 2.0.2 at the moment. Could you point out the commit and I could try that however?

[OnTapKristjan]

@craigcarnell it's probably this one: 32ca5c9

[rhoerr]

I applied the fix manually; can confirm it fixes the problem for me.

[ifekaj]

This solved my issue mentioned in #2878