Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] magento/magento2#: Remove a redundant getMappedNums from a loop #30031

Closed
2 tasks
m2-assistant bot opened this issue Sep 14, 2020 · 3 comments · Fixed by #27939
Closed
2 tasks

[Issue] magento/magento2#: Remove a redundant getMappedNums from a loop #30031

m2-assistant bot opened this issue Sep 14, 2020 · 3 comments · Fixed by #27939
Assignees
@atwixfirster
Labels
Component: GraphQL GraphQL Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020 •
edited by magento-engcom-team
Loading

(i) This ticket is created automatically based on a verified GitHub issue.

{panel}
If you are starting to work on this Jira ticket, please notify issue reporter and authors of related community pull requests (if any) that you are going to work on this issue:

  1. Assign #30031 issue to yourself on Magento GitHub
  2. Add comment "Internal Magento team is working on this issue right now."
    {panel}
    This issue is automatically created based on existing pull request: magento/magento2#: Remove a redundant getMappedNums from a loop #27939: magento/magento2#: Remove a redundant getMappedNums from a loop ------- ######Preconditions (*)
  3. 2.4-develop

######Description (*)

Removes a redundant getMappedNums from a loop.

Before changes:

!bef79987364-fc982d80-84b5-11ea-8f6d-d0047b8245fa.png|thumbnail!

After fix:

!aft79987388-028e0e80-84b6-11ea-8005-51fb618b8fb1.png|thumbnail!

######Related Pull Requests

######Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

######Steps to reproduce (*)

  1. ...
  2. ...

######Expected result (*)
...

######Actual result (*)

######Questions or comments

######Contribution checklist (*)

  • < ] Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • [ > All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: GraphQL GraphQL Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 14, 2020
@m2-assistant m2-assistant bot mentioned this issue Sep 14, 2020
Merged
5 tasks
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 14, 2020
@engcom-Bravo engcom-Bravo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 29, 2020
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 29, 2020
@engcom-Bravo engcom-Bravo added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 29, 2020
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 29, 2020
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 29, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 29, 2020
@magento-engcom-team
Copy link
Contributor

@engcom-Bravo Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento magento deleted a comment from magento-engcom-team Sep 29, 2020
@magento magento deleted a comment from magento-engcom-team Sep 29, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 29, 2020
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Sep 29, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-38070 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: ready for dev and removed Progress: PR in progress labels Sep 29, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #27939 by @atwixfirster in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 30, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atwixfirster atwixfirster

Labels
Component: GraphQL GraphQL Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

magento/magento2#: Remove a redundant getMappedNums from a loop atwixfirster/magento2
3 participants
@atwixfirster @magento-engcom-team @engcom-Bravo