How to fix magento compatibility issue in both version 2.3 & 2.4

[sucharita-ksolves]

For modify sales pdf design , I have overwrite pdf model file (module-sales/Model/Order/Pdf/Invoice.php, module-sales/Model/Order/Pdf/Shipment.php ,

As magento 2.3 and 2.4 version __construct function changed, so When I overwrite it will not work both version. How can I fix it ,so it will work in both version with same code.

[m2-assistant]

Hi @sucharita-ksolves. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[krishprakash]

Hi @sucharita-ksolves. Thank you for your report.
The GitHub issue tracker is intended for Magento Core technical issues only.
Please refer to the Community Forums or the Magento Stack Exchange site for advice or general discussion about this issue.

[hostep]

Yeah, that change was a pretty bad one not done in a backwards compatible way.

We had the same problem with one of our modules after upgrading from Magento 2.3.5 to 2.3.6
We needed the module to be compatible with both 2.3.5 and 2.3.6 so we needed to figure out a solution.

Our solution - and it's probably going to be frowned upon - was to remove the constructor and use the ObjectManager directly to instantiate classes we needed.

For example, use something like this to instantiate SomeClass:

<?php

...
use Magento\Framework\App\ObjectManager;
use Magento\Sales\Model\Order\Pdf\Invoice as InvoicePdfModel;
...

class Whatever extends InvoicePdfModel
{
    private $someClassInstance;

    private function getSomeClassInstance()
    {
        if ($this->someClassInstance === null) {
            $this->someClassInstance = ObjectManager::getInstance()->get(SomeClass::class);
        }
        
        return $this->someClassInstance;
    }
    ....
}