Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpstan/phpstan dependency to PHP 8 compatible version #31176

Closed
sivaschenko opened this issue Dec 4, 2020 · 4 comments · Fixed by #30581
Closed

Update phpstan/phpstan dependency to PHP 8 compatible version #31176

sivaschenko opened this issue Dec 4, 2020 · 4 comments · Fixed by #30581
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Project: PHP8 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@sivaschenko
Copy link
Member

Description (*)

Update phpstan/phpstan dependency version from ">=0.12.3 <=0.12.23" to ">=0.12.3 <=0.12.54"
Ensure composer install runs on PHP 7.4 and 8.0

Expected behavior (*)

Benefits

Additional information

@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Dec 17, 2020

Commend moved to #31303 (comment)

@ihor-sviziev ihor-sviziev self-assigned this Dec 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2020

Hi @ihor-sviziev. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot assigned hostep and unassigned sivaschenko Dec 18, 2020
@ihor-sviziev ihor-sviziev removed their assignment Jan 25, 2021
sivaschenko added a commit to hostep/magento2 that referenced this issue Jan 27, 2021
@m2-community-project m2-community-project bot added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jan 27, 2021
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, @hostep.

Thank you for your report and collaboration!

The related internal Jira ticket MC-39645 was closed as Complete.

The fix will be available with the upcoming 2.4.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 12, 2021
hostep pushed a commit to hostep/magento2 that referenced this issue Mar 30, 2021
hostep pushed a commit to hostep/magento2 that referenced this issue Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Project: PHP8 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
6 participants