Skip to content

[EY] Support CORS for GraphQL #31195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magento-engcom-team opened this issue Dec 8, 2020 · 4 comments · May be fixed by #31484
Open

[EY] Support CORS for GraphQL #31195

magento-engcom-team opened this issue Dec 8, 2020 · 4 comments · May be fixed by #31484
Labels
feature request Partner: EY Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: PR in progress Project: GraphQL

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Dec 8, 2020

As a web developer, I want Magento to support the CORS standard:

https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS

so that I can develop my applications according to defined best practices. 

Use env for settings not system config

Other Issues:

Related issue: https://github.com/magento/magento2/issues/28561 (original issue: #8399)

Acceptance Criteria:

Implement CORS support as detailed here: https://enable-cors.org/server.html

@magento-engcom-team magento-engcom-team added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev labels Dec 8, 2020
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-39743

@m2-assistant
Copy link

m2-assistant bot commented Dec 8, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team changed the title [Zilker] CORS Support :: Community PR review and delivery [Zilker] CORS Support for GraphQL Dec 8, 2020
@magento-engcom-team magento-engcom-team changed the title [Zilker] CORS Support for GraphQL [Zilker] Support CORS for GraphQL Dec 8, 2020
@G-Arvind G-Arvind linked a pull request Dec 29, 2020 that will close this issue
4 tasks
@mauragcyrus mauragcyrus changed the title [Zilker] Support CORS for GraphQL [EY] Support CORS for GraphQL Feb 10, 2021
@engcom-November engcom-November self-assigned this Sep 1, 2022
@m2-assistant
Copy link

m2-assistant bot commented Sep 1, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

CORs support for GraphQl is not available in Magento which is the existing behavior of Magento. Hence considering this as feature request.
However this (package)[https://github.com/graycoreio/magento2-cors] allows you to securely add the necessary CORS headers to the Magento 2 GraphQL or REST APIs with ease.

@engcom-November engcom-November removed their assignment Sep 1, 2022
@G-Arvind G-Arvind removed their assignment Sep 1, 2022
@engcom-Hotel engcom-Hotel moved this to Pull Request in Progress in Feature Requests Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Partner: EY Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: PR in progress Project: GraphQL
Projects
Status: Pull Request in Progress
Development

Successfully merging a pull request may close this issue.

5 participants