[GraphQl] Exception are not translated to store scope.

[Hexmage]

Preconditions (*)

Reproduced on

1. Magento 2.3.5-p2
2. Magento 2.4.1

Steps to reproduce (*)

1. Set the locale of a store to anything but en_US.
2. Create a translation file/database entry with one of the translatable exception strings (eg: 'currentPage value must be greater than 0.' to 'This text is translated')
3. Make a GraphQl request that will cause the exception to trigger with the Store header for the store set in 1.

query productList{
    products( currentPage: 0) {
        items {
            id
            name
        }
    }
}

Expected result (*)

{
    "errors": [
        {
            "message": "This text is translated.",
            "extensions": {
                "category": "graphql-input"
            },
            "locations": [
                {
                    "line": 2,
                    "column": 3
                }
            ],
            "path": [
                "products"
            ]
        }
    ],
    "data": {
        "products": null
    }
}

Actual result (*)

{
    "errors": [
        {
            "message": "currentPage value must be greater than 0.",
            "extensions": {
                "category": "graphql-input"
            },
            "locations": [
                {
                    "line": 2,
                    "column": 3
                }
            ],
            "path": [
                "products"
            ]
        }
    ],
    "data": {
        "products": null
    }
}

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Hexmage. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[t-heuser]

Having the same issue, can confirm for Magento 2.4.1.

[t-heuser]

This works as a temporary solution: https://stackoverflow.com/questions/61770306/while-working-with-the-magento-2-graphql-it-seems-that-the-string-translation-do

[ReggieTe]

I'm experiencing the same issue on Magento 2.3.4 and the patch on https://stackoverflow.com/questions/61770306/while-working-with-the-magento-2-graphql-it-seems-that-the-string-translation-do seems not to be working

[m2-assistant]

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[Hexmage]

I'm experiencing the same issue on Magento 2.3.4 and the patch on https://stackoverflow.com/questions/61770306/while-working-with-the-magento-2-graphql-it-seems-that-the-string-translation-do seems not to be working

It only seems to translate to the default store locale so if you have multiple locales it breaks.

[Hexmage]

<?php

namespace Vender\GraphQlExceptionMessageFix\Plugin\Controller;

use Magento\Framework\App\Area;
use Magento\Framework\App\AreaList;
use Magento\Framework\App\RequestInterface;
use Magento\Framework\App\State;
use Magento\Framework\Locale\ResolverInterface;
use Magento\Framework\TranslateInterface;
use Magento\GraphQl\Controller\GraphQl;
use Magento\Store\Model\StoreManagerInterface;

class GraphQlPlugin
{
    /** @var AreaList $areaList */
    private $areaList;

    /** @var State $appState */
    private $appState;
    /**
     * @var StoreManagerInterface
     */
    private $storeManager;
    /**
     * @var ResolverInterface
     */
    private $localeResolver;

    public function __construct(
        AreaList $areaList,
        State $appState,
        TranslateInterface $translation,
        ResolverInterface $localeResolver,
        StoreManagerInterface $storeManager
    ) {
        $this->areaList = $areaList;
        $this->appState = $appState;
        $this->translation = $translation;
        $this->localeResolver = $localeResolver;
        $this->storeManager = $storeManager;
    }

    public function beforeDispatch(GraphQl $subject, RequestInterface $request)
    {
        $area = $this->areaList->getArea($this->appState->getAreaCode());
        $storeIdOrCode = $request->getHeader('store') ?: 0;
        $locale = $this->storeManager->getStore($storeIdOrCode)->getConfig('general/locale/code');
        $this->localeResolver->setLocale($locale);
        $this->translation->setLocale($locale);
        $area->load(Area::PART_TRANSLATE);
    }
}

Working version of the plugin at https://stackoverflow.com/questions/61770306/while-working-with-the-magento-2-graphql-it-seems-that-the-string-translation-do

[rikwillems]

@Hexmage when I patch the GraphQL controller the translation works at store level too. In that case there is no need to determine the correct language.

[Hexmage]

@rikwillems I determine the correct language because it can be different for each storeview.

The original fix only looked at the locale set at the highest level. So if you had multiple storeviews with different locales it didn't work.

[ihor-sviziev]

@sidolov @sivaschenko seems like quite an important issue for single-page applications, like PWA, or by using GraphQL on the frontend and showing exceptions to users.
Let's set priority to p2 or even p1.

[shikhamis11]

@ihor-sviziev I agree. It's quite an important bug since multi-store and multi language features are already there at pwa studio with the release of 2.4.2. This should be addressed soon.

[gabrieldagama]

Error messages may be changed to error codes, and PWA and any other application consuming the GraphQL API should perform the translation on the frontend application, similar issue with #27600

Cc. @cpartica

[Hexmage]

@gabrieldagama
This feels like a waste of having the entire translation functionality in Magento. Adding Error Codes is fine because you might want to do something different based on the error code. But seeing as all other endpoints (soap, rest, the html frontend) do translate their output based on the store scope it would be weird that only graphql doesn't do this.

And by putting the burden of translations on the frontend application, you'll increase it's size which you are trying to prevent especially if it will be running client side.

[rikwillems]

In my case I'm reading the cart/quote items that have custom made options. The labels of these options were not translated which doesn't make any sense, also not regarding PWA. My fix is:

Load the translations when the GraphQL controller is dispatched.
===================================================================
--- Controller/GraphQl.php
+++ Controller/GraphQl.php
@@ -7,6 +7,7 @@

 namespace Magento\GraphQl\Controller;

+use Magento\Framework\App\Area;
 use Magento\Framework\App\FrontControllerInterface;
 use Magento\Framework\App\Request\Http;
 use Magento\Framework\App\RequestInterface;
@@ -89,6 +90,9 @@
      */
     private $contextFactory;

+    /** @var \Magento\Framework\App\State $appState */
+    private $appState;
+
     /**
      * @param Response $response
      * @param SchemaGeneratorInterface $schemaGenerator
@@ -114,7 +118,8 @@
         QueryFields $queryFields,
         JsonFactory $jsonFactory = null,
         HttpResponse $httpResponse = null,
-        ContextFactoryInterface $contextFactory = null
+        ContextFactoryInterface $contextFactory = null,
+        \Magento\Framework\App\AreaList $areaList
     ) {
         $this->response = $response;
         $this->schemaGenerator = $schemaGenerator;
@@ -127,6 +132,7 @@
         $this->jsonFactory = $jsonFactory ?: ObjectManager::getInstance()->get(JsonFactory::class);
         $this->httpResponse = $httpResponse ?: ObjectManager::getInstance()->get(HttpResponse::class);
         $this->contextFactory = $contextFactory ?: ObjectManager::getInstance()->get(ContextFactoryInterface::class);
+        $this->areaList = $areaList;
     }

     /**
@@ -138,6 +144,8 @@
      */
     public function dispatch(RequestInterface $request) : ResponseInterface
     {
+        $this->areaList->getArea(Area::AREA_GRAPHQL)->load(Area::PART_TRANSLATE);
+
         $statusCode = 200;
         $jsonResult = $this->jsonFactory->create();
         try {

[cpartica]

Error messages may be changed to error codes, and PWA and any other application consuming the GraphQL API should perform the translation on the frontend application, similar issue with #27600

Cc. @cpartica

[github-jira-sync-bot]

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-1946

[github-jira-sync-bot]

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-1946

[github-jira-sync-bot]

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.magento.com/browse/AC-1946

[slackerzz]

Is this fixed? In which magento version?

[cpartica]

2.4.4 - you just have to wait for it
Back in December we diverged branches for 2.4.4 and 2.4-develop for regression purposes and for ~ 3 months this process is invisible to the main branch
You will see the PR automerged when 2.4.4 is released

[engcom-November]

Hi,
This issue got fixed in the scope of the internal Jira ticket AC-1946 by the internal team

Related commits: https://github.com/magento/magento2/search?q=AC-1946&type=commits
Based on Jira, target version is 2.4.4
Thank you.

[zakdma]

This issue is still present for 2.4.7. I see changes but they does not work