Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated interfaces part 1 #32061

Open
sivaschenko opened this issue Feb 9, 2021 · 11 comments
Open

Remove deprecated interfaces part 1 #32061

sivaschenko opened this issue Feb 9, 2021 · 11 comments
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Project: API Changes
Milestone

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 9, 2021

The following deprecated interfaces should be removed in 2.5-develop branch

  1. app/code/Magento/CatalogSearch/Model/ResourceModel/Fulltext/Collection/DefaultFilterStrategyApplyCheckerInterface.php: Deprecated since May 2019
  2. app/code/Magento/MediaGalleryApi/Model/Asset/Command/DeleteByDirectoryPathInterface.php: Can be removed, has been deprecated since April 2020
  3. app/code/Magento/MediaGalleryApi/Model/Asset/Command/DeleteByPathInterface.php: Can be removed, has been deprecated since April 2020
  4. app/code/Magento/MediaGalleryApi/Model/Asset/Command/GetByIdInterface.php: Can be removed, has been deprecated since April 2020
  5. app/code/Magento/MediaGalleryApi/Model/Asset/Command/GetByPathInterface.php: Can be removed, has been deprecated since April 2020
  6. app/code/Magento/MediaGalleryApi/Model/Asset/Command/SaveInterface.php: Can be removed, has been deprecated since April 2020
  7. app/code/Magento/MediaGalleryApi/Model/Keyword/Command/GetAssetKeywordsInterface.php: Can be removed, has been deprecated since April 2020
  8. app/code/Magento/MediaGalleryApi/Model/Keyword/Command/SaveAssetKeywordsInterface.php: Can be removed, has been deprecated since April 2020
  9. app/code/Magento/Payment/Model/Method/ConfigInterface.php: Deprecated since 2018
  10. app/code/Magento/Search/Model/QueryFactoryInterface.php: Deprecated since 2017
  11. app/code/Magento/Store/Api/StoreResolverInterface.php: Deprecated since June 2018, has replacement
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

@adamphh
Copy link
Contributor

adamphh commented Feb 10, 2021

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2021

Hi @adamphh! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@adamphh
Copy link
Contributor

adamphh commented Feb 10, 2021

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2021

Hi @adamphh! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@adamphh
Copy link
Contributor

adamphh commented Feb 10, 2021

@magento I am working on this

adamphh added a commit to adamphh/magento2 that referenced this issue Feb 24, 2021
(Fix issue of WebAPI Tests and Unit Tests)
adamphh added a commit to adamphh/magento2 that referenced this issue Feb 25, 2021
(Fix issue Could not retrieve media assets)
@Usik2203
Copy link
Contributor

Usik2203 commented Mar 3, 2021

@magento I am working on this

@Usik2203
Copy link
Contributor

@magento I am working on this

@Usik2203
Copy link
Contributor

Usik2203 commented Apr 20, 2021

Hi @sivaschenko @gabrieldagama
i have question about 11. app/code/Magento/Store/Api/StoreResolverInterface.php: Deprecated since June 2018, has replacement interface.

Should \Magento\Store\Model\StoreResolver class which implements app/code/Magento/Store/Api/StoreResolverInterface.php interface also be removed or not ?

Thank you !

@sivaschenko
Copy link
Member Author

Hi @Usik2203 , the replacement implementation does depend on StoreResolver, so I don't think it can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Project: API Changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants