Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark interfaces deprecated #32063

Open
sivaschenko opened this issue Feb 9, 2021 · 2 comments
Open

Mark interfaces deprecated #32063

sivaschenko opened this issue Feb 9, 2021 · 2 comments
Assignees
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: PR in progress Project: API Changes
Milestone

Comments

@sivaschenko
Copy link
Member

The following interfaces should be marked as deprecated

  1. app/code/Magento/Analytics/Model/ConfigInterface.php: should be replaced by Magento\Framework\Config\DataInterface
  2. app/code/Magento/Analytics/Model/Connector/Http/ClientInterface.php: should be replaced by Psr\Http\Client\ClientInterface
  3. app/code/Magento/Analytics/Model/Connector/Http/ResponseHandlerInterface.php: related to app/code/Magento/Analytics/Model/Connector/Http/ClientInterface.php
  4. app/code/Magento/Analytics/ReportXml/ConfigInterface.php: should be replaced by Magento\Framework\Config\DataInterface
  5. app/code/Magento/GraphQl/Model/Query/ContextFactoryInterface.php: Interfaces are not necessary for factories, should be deprecated and later removed
  6. app/code/Magento/Sales/Model/ResourceModel/HelperInterface.php: 1 usage, need to be eliminated in favor of private implementation
  7. lib/internal/Magento/Framework/Filter/Encrypt/AdapterInterface.php: No implementations, there are preference but they implement zend interface directly. Seems unused
  8. lib/internal/Magento/Framework/GraphQl/Query/PostFetchProcessorInterface.php: Not used
  9. lib/internal/Magento/Framework/Model/Operation/ReadInterface.php: Not used
  10. lib/internal/Magento/Framework/Model/Operation/WriteInterface.php: Not used
  11. lib/internal/Magento/Framework/Model/ResourceModel/Db/ProcessEntityRelationInterface.php: Not used
  12. lib/internal/Magento/Framework/Module/ResourceInterface.php: Implementation is deprecated with explanation why
  13. lib/internal/Magento/Framework/View/Asset/SourceFileGeneratorInterface.php: Not used
  14. lib/internal/Magento/Framework/View/Design/Theme/Domain/PhysicalInterface.php: Not used
  15. lib/internal/Magento/Framework/View/Design/Theme/Domain/StagingInterface.php: Not used
  16. lib/internal/Magento/Framework/View/Design/Theme/Domain/VirtualInterface.php: Not used
  17. app/code/Magento/CustomerGraphQl/Api/ValidateCustomerDataInterface.php: GraphQL modules should be extensible via GraphQL schema. They are not domain modules and must not contain Api folder
  18. app/code/Magento/Catalog/Model/EntityInterface.php: Unused interface, exists for 5 years
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: PR in progress Project: API Changes
Projects
None yet
Development

No branches or pull requests

3 participants