-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not use passive listeners to improve scrolling performance #34158
Comments
Hi @ia-gaurav. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
the fix maybe take times even a years to deploy/merge into codebase |
Personally I've been using the following patch on jquery for ages:
|
Add to the file lib/web/jquery/patches/jquery.js |
Created pr for jquery newer version here @ia-gaurav See my link above |
@mrtuvn - can u tell what to add in lib/web/jquery/patches/jquery.js |
Hi @engcom-Hotel. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Hotel, here is your Magento Instance: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering |
@magento give me 2.4-develop instance |
Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Hotel, here is your Magento Instance: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering |
Hello @ia-gaurav, We have checked this issue on the cloud instance, but we are unable to reproduce the issue. The issue you mentioned in the description is not visible on both desktop and mobile reports. Please let us know if we have missed anything in order to reproduce the issue. Thanks |
Added solution fix in above link in my comment |
@engcom-Hotel You may not notice this line |
@magento give me 2.4-develop instance |
Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Hotel, here is your Magento Instance: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-develop.instances.magento-community.engineering |
@magento give me 2.4.3 instance |
Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Hotel, here is your Magento Instance: https://6dd90eea1a8e2a0fc4db3ee65e365b93-2-4-3.instances.magento-community.engineering |
Hello @mrtuvn, Thanks for the updates! I was checking the homepage, the issue is not visible there but inner page the issue can be reproducible. Please have a look at to below screenshot: @ia-gaurav Since the issue is reproducible, we are confirming this issue. Thanks |
✅ Jira issue https://jira.corp.magento.com/browse/AC-1541 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue. |
❌ You don't have permission to export this issue. |
@engcom-Hotel: now that you have confirmed this, could you edit your post with those super large images and remove them? Those large images cause issues in our browsers while scrolling through this issue due to taking up a lot of resources while trying to display them. Much appreciated, thanks! |
Of course, you always start from Luma, but I think there will be problems with the adaptation of a shop at the latest. Here is an example from my current dev environment. |
Preconditions :
Magento 2.4 latest version
Steps 1: Check you site via google page speed :https://developers.google.com/speed/pagespeed/insights
Steps 2: Check audit report you will see below issues
Does not use passive listeners to improve scrolling performance
Consider marking your touch and wheel event listeners as
passive
to improve your page's scroll performance. Learn more.Source
…en_US/jquery.min.js:313:558
Can it be fixed are it is causing issue with mobile perfomace
The text was updated successfully, but these errors were encountered: