-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The js error when swipe gallery images on the product page (touch events) #34282
Comments
Hi @glevhen. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Lima. Thank you for working on this issue.
|
Hi @glevhen, Thank you for reporting the issue. Verified the issue and able to reproduce on Magento 2.4-develop. Attached below screenshot of the console errors that I got while trying to swipe images on product detail page using Chrome DevTools for mobile: Based on above analysis, confirming the issue. |
✅ Jira issue https://jira.corp.magento.com/browse/AC-1475 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Lima. Thank you for verifying the issue. |
#35017 |
Can you verify with latest code upstream 2.4-develop ? |
Hi @engcom-Hotel. Thank you for working on this issue.
|
Hello @glevhen, We have tried to reproduce the issue in the latest 2.4-develop branch and the issue is no more reproducible for us. Hence closing this issue. Thanks |
Magento 2.4.3
Open product page in chrome browser and swipe product images in the gallery
make sure you swiping via touch event (you can use chrome mobile device emulation or real devices for this)
Swiping product images cause js errors
fotorama.js:1222 Unable to preventDefault inside passive event listener invocation.
the issue caused by this commit 2f5b57a#diff-c4a96bcd0b56dc98fdc1c5af6c8a86d6560587bbc80caabe9b3ccabd047675d0
because fotorama call
e.preventDefault
https://github.com/magento/magento2/blob/2.4-develop/lib/web/fotorama/fotorama.js#L1222
inside of passive event listener
https://github.com/magento/magento2/blob/2.4-develop/lib/web/fotorama/fotorama.js#L1143
The text was updated successfully, but these errors were encountered: