Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The js error when swipe gallery images on the product page (touch events) #34282

Closed
glevhen opened this issue Oct 8, 2021 · 10 comments
Closed
Assignees
Labels
Area: Content Component: Image Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@glevhen
Copy link

glevhen commented Oct 8, 2021

Magento 2.4.3
Open product page in chrome browser and swipe product images in the gallery
make sure you swiping via touch event (you can use chrome mobile device emulation or real devices for this)
Swiping product images cause js errors
fotorama.js:1222 Unable to preventDefault inside passive event listener invocation.
image

the issue caused by this commit 2f5b57a#diff-c4a96bcd0b56dc98fdc1c5af6c8a86d6560587bbc80caabe9b3ccabd047675d0

because fotorama call e.preventDefault
https://github.com/magento/magento2/blob/2.4-develop/lib/web/fotorama/fotorama.js#L1222
inside of passive event listener
https://github.com/magento/magento2/blob/2.4-develop/lib/web/fotorama/fotorama.js#L1143

@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2021

Hi @glevhen. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@glevhen
Copy link
Author

glevhen commented Oct 8, 2021

#34162
3eda0c8

@engcom-Lima engcom-Lima self-assigned this Oct 13, 2021
@engcom-Lima engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Oct 13, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2021

Hi @engcom-Lima. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Lima
Copy link
Contributor

Hi @glevhen,

Thank you for reporting the issue.

Verified the issue and able to reproduce on Magento 2.4-develop. Attached below screenshot of the console errors that I got while trying to swipe images on product detail page using Chrome DevTools for mobile:

Screenshot 2021-10-13 at 12 25 21 PM

Based on above analysis, confirming the issue.

@engcom-Lima engcom-Lima added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Content Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 13, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-1475 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2021

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Alfa engcom-Alfa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 19, 2021
@engcom-Alfa engcom-Alfa added the Reported on 2.4.3 Indicates original Magento version for the Issue report. label Oct 19, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Jun 12, 2022

#35017
Seem this update may fit with your case

@mrtuvn
Copy link
Contributor

mrtuvn commented May 18, 2023

Can you verify with latest code upstream 2.4-develop ?
Thanks

@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
@engcom-Hotel engcom-Hotel self-assigned this Oct 7, 2024
Copy link

m2-assistant bot commented Oct 7, 2024

Hi @engcom-Hotel. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Hotel
Copy link
Contributor

Hello @glevhen,

We have tried to reproduce the issue in the latest 2.4-develop branch and the issue is no more reproducible for us.

Hence closing this issue.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Component: Image Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Ready for Development
Development

No branches or pull requests

6 participants