Upgrade jquery to 3.6.0 #34162

mrtuvn · 2021-09-26T09:22:36Z

Description (*)

This pull efforts to upgrade jquery to version 3.6.0
added resolve passive event listeners problem on mobile (touchstart) when call preventDefault

https://cdn.jsdelivr.net/npm/jquery@3.6.0/dist/jquery.js
minify version
https://cdn.jsdelivr.net/npm/jquery@3.6.0/dist/jquery.min.js

jquery-migrate 3.3.2
https://code.jquery.com/jquery-migrate-3.3.2.js

Guide
https://jquery.com/upgrade-guide/3.0/

Remain works
-remove old patches (jQuery UI - v1.12.1)
https://github.com/magento/magento2/tree/2.4-develop/lib/web/jquery/patches
seperate each components to individual package

-check compatible with remain widgets
https://github.com/magento/magento2/tree/2.4-develop/lib/web/jquery (Main here)
Other places in external modules, EE, v.v

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Should we minimal jquery widget ?

'jquery-ui-modules/core',
'jquery-ui-modules/accordion',
'jquery-ui-modules/button',
'jquery-ui-modules/datepicker',
'jquery-ui-modules/dialog',
'jquery-ui-modules/draggable',
'jquery-ui-modules/effect',
'jquery-ui-modules/menu',
'jquery-ui-modules/mouse',
'jquery-ui-modules/position',
'jquery-ui-modules/progressbar',
'jquery-ui-modules/resizable',
'jquery-ui-modules/selectable',
'jquery-ui-modules/slider',
'jquery-ui-modules/sortable',
'jquery-ui-modules/tabs',
'jquery-ui-modules/timepicker',
'jquery-ui-modules/tooltip',
'jquery-ui-modules/widget'

Instead load all above. We only use on demands files

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-09-26T09:22:38Z

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mrtuvn · 2021-10-01T14:51:38Z

remain task upgrade jquery ui (current latest 1.12.1) following magento seperate to modules

xmav · 2021-10-01T15:30:10Z

Hi @mrtuvn !
Thank you for this contribution! Cannot wait to see build results )

xmav · 2021-10-02T04:02:45Z

@mrtuvn Let me share some info: We(magento team) are working on jquery-ui upgrade. Please contact me if you plan to work on jquery-ui upgrade so we can sync and avoid duplication in efforts

mrtuvn · 2021-10-02T04:52:04Z

Hi @xmav you can work directly on this branch . If you need write access branch please let me know.

fascinosum · 2021-10-04T16:11:49Z

@magento run all tests

magento-automated-testing · 2021-10-04T16:11:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-10-17T07:04:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-10-17T15:49:02Z

@xmav Can you deliver this error note to team

I also got this issue before
related with component mage/backend/tabs

xmav · 2021-10-21T01:32:57Z

Hi @mrtuvn
Could you provide steps to reproduce issue above ?

mrtuvn · 2021-10-21T06:17:28Z

Upgrade to jquery 3.6.0 + jquery ui to latest -> Go to admin
open console tab
You may got this notice that._tabId is not function

xmav · 2021-10-23T02:51:00Z

Got it. We are currently working on jqueryUI only so we don't see this error yet

mrtuvn · 2021-11-03T11:00:53Z

@magento run Unit Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2021-11-03T11:00:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-11-04T23:51:25Z

@krissyhiserote i will let this PR like this. Other fixes can do by another seperate PR. So you team can keep working as normal. Later code merge to develop i will sync with this. Seem a long road ahead for check new compatible

bondmedia007 · 2021-11-09T11:37:14Z

Afternoon all, Our Penetration testers have found that the current jQuery version used in Magento 2.4.3 is vulnerable in some means to hackers does this thread relate to the issue found?

mrtuvn · 2021-11-09T13:03:37Z

2.4.3 still use old version jquery. This pr will update to higher version. Internal team currently working upgrade compatible with new update

bondmedia007 · 2021-11-09T13:11:07Z

@mrtuvn thanks for letting me know, when you say internal team do you mean the guys working at Magento?

mrtuvn · 2021-11-18T08:37:00Z

Yes @xmav may know more details

Rrego6 · 2021-11-22T18:46:45Z

Hi there, @mrtuvn . If you get a chance, could you help me understand the reason for changes to lib/web/jquery/patches/jquery.js? To me, it makes more sense to remove this file entirely.

mrtuvn · 2021-11-22T23:32:37Z

That file apply fixes for lighthouse warn "Does not use passive listeners to improve scrolling performance"

…o upgrade-jquery-3.6.0

mrtuvn · 2021-11-23T00:09:16Z

Pull latest code to branch
@magento run all tests

magento-automated-testing · 2021-11-23T00:09:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Rrego6 · 2021-11-23T22:03:29Z

@mrtuvn I don't think that lighthouse warnings are necessary to fix for this upgrade. The upgrade does not cause these issues correct?

This change to patches breaks our unit tests since the function signature for the callback in the patch is not valid. (ns is null)

We will create a separate ticket to track and investigate this.

mrtuvn · 2021-11-24T00:28:28Z

I can remove that file in this scope of ticket. And tracking warning lighthouse in seperate PR/ticket

mrtuvn · 2021-11-24T00:37:57Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Unit Tests

magento-automated-testing · 2021-11-24T00:38:07Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-11-24T02:31:18Z

Deleted file patches jquery.
@magento run Unit Tests

magento-automated-testing · 2021-11-24T02:31:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Revert changes to avoid conflicts

mrtuvn · 2021-11-25T01:51:06Z

@magento run all tests

magento-automated-testing · 2021-11-25T01:51:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-11-30T08:29:02Z

Closed this because internal team already delivery updated jquery 3.6.0 to mainline codebase (2.4-develop branch)

bondmedia007 · 2021-11-30T08:31:29Z

good morning @mrtuvn thanks for keeping us updated, when will the upgraded Jquery be available to upgrade on M 2.4.3

mrtuvn · 2021-11-30T08:34:23Z

I'm not sure maybe @xmav @sidolov may know this

bondmedia007 · 2021-11-30T08:45:31Z

Thank you @mrtuvn look forward to hearing from @xmav and @sidolov have a great day.

xmav · 2021-11-30T16:06:01Z

I am not aware of plans to backport this to 2.4.3

kirmorozov · 2023-03-18T22:01:44Z

Good Luck :) I tried it years ago.
#13685

magento-engcom-team added Area: Lib/Frontend Release Line: 2.4 labels Sep 26, 2021

mrtuvn force-pushed the upgrade-jquery-3.6.0 branch from 44486db to 7389462 Compare September 26, 2021 09:32

m2-community-project bot added the Progress: pending review label Sep 26, 2021

mrtuvn mentioned this pull request Sep 30, 2021

Does not use passive listeners to improve scrolling performance #34158

Open

andrewbess self-assigned this Oct 1, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 1, 2021

fascinosum added the Project: Platform Health label Oct 4, 2021

glevhen mentioned this pull request Oct 8, 2021

The js error when swipe gallery images on the product page (touch events) #34282

Closed

mrtuvn force-pushed the upgrade-jquery-3.6.0 branch 2 times, most recently from ce9a913 to 47dbe8c Compare November 3, 2021 15:55

fascinosum assigned krissyhiserote Nov 9, 2021

Merge branch '2.4-develop' of https://github.com/magento/magento2 int…

29f6c82

…o upgrade-jquery-3.6.0

Remove old jquery patches

3d78de2

Update magnify.js

be7200a

Revert changes to avoid conflicts

mrtuvn closed this Nov 30, 2021

m2-community-project bot removed the Progress: review label Nov 30, 2021

Upgrade jquery to 3.6.0 #34162

Upgrade jquery to 3.6.0 #34162

Conversation

mrtuvn commented Sep 26, 2021 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Sep 26, 2021

mrtuvn commented Oct 1, 2021

xmav commented Oct 1, 2021

xmav commented Oct 2, 2021

mrtuvn commented Oct 2, 2021 • edited Loading

fascinosum commented Oct 4, 2021

magento-automated-testing bot commented Oct 4, 2021

magento-automated-testing bot commented Oct 17, 2021

mrtuvn commented Oct 17, 2021 • edited Loading

xmav commented Oct 21, 2021

mrtuvn commented Oct 21, 2021 • edited Loading

xmav commented Oct 23, 2021

mrtuvn commented Nov 3, 2021

magento-automated-testing bot commented Nov 3, 2021

mrtuvn commented Nov 4, 2021 • edited Loading

bondmedia007 commented Nov 9, 2021

mrtuvn commented Nov 9, 2021 • edited Loading

bondmedia007 commented Nov 9, 2021

mrtuvn commented Nov 18, 2021

Rrego6 commented Nov 22, 2021

mrtuvn commented Nov 22, 2021

mrtuvn commented Nov 23, 2021

magento-automated-testing bot commented Nov 23, 2021

Rrego6 commented Nov 23, 2021 • edited Loading

mrtuvn commented Nov 24, 2021

mrtuvn commented Nov 24, 2021

magento-automated-testing bot commented Nov 24, 2021

mrtuvn commented Nov 24, 2021 • edited Loading

magento-automated-testing bot commented Nov 24, 2021

mrtuvn commented Nov 25, 2021

magento-automated-testing bot commented Nov 25, 2021

mrtuvn commented Nov 30, 2021 • edited Loading

bondmedia007 commented Nov 30, 2021

mrtuvn commented Nov 30, 2021

bondmedia007 commented Nov 30, 2021

xmav commented Nov 30, 2021

kirmorozov commented Mar 18, 2023

mrtuvn commented Sep 26, 2021 •

edited

Loading

mrtuvn commented Oct 2, 2021 •

edited

Loading

mrtuvn commented Oct 17, 2021 •

edited

Loading

mrtuvn commented Oct 21, 2021 •

edited

Loading

mrtuvn commented Nov 4, 2021 •

edited

Loading

mrtuvn commented Nov 9, 2021 •

edited

Loading

Rrego6 commented Nov 23, 2021 •

edited

Loading

mrtuvn commented Nov 24, 2021 •

edited

Loading

mrtuvn commented Nov 30, 2021 •

edited

Loading