Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database port missing in Magento\TestFramework\Db\Mysql #3529

Closed
tkn98 opened this issue Feb 24, 2016 · 3 comments
Closed

Database port missing in Magento\TestFramework\Db\Mysql #3529

tkn98 opened this issue Feb 24, 2016 · 3 comments

Comments

@tkn98
Copy link
Contributor

tkn98 commented Feb 24, 2016

The methods:

  1. Magento\TestFramework\Db\Mysql::storeDbDump()
  2. Magento\TestFramework\Db\Mysql::restoreFromDbDump()

(and perhaps others) are creating mysql / mysqldump commands to be invoked via shell. They make use of the --host command-line switch without adressing a potential (optional) port configuration (--port=#).

The configuration format is:

host[:port]

As the configuration data is taken over unchanged, every configuration with a port given makes these CLI commands fail then.

This flaw blocks users with mysql port configuration making use of the test-suite.

Reference: #2735 #2736

@okorshenko okorshenko added the PS label Mar 10, 2016
@ktomk
Copy link
Contributor

ktomk commented Apr 2, 2016

Just a little reminder that we need to file a request for this with Magento support.

@KrystynaKabannyk
Copy link

Hello @tkn98, this issue has been fixed in the 2.1.0 Release, that's why I'm closing it. If you any questions or additional information regarding the issue feel free to reopen it or create a new one.

@tkn98
Copy link
Contributor Author

tkn98 commented Jul 6, 2016

@KrystynaKabannyk: May I ask to share the hash of the commit in which the fix has been applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants