-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php8.1 M2.4.4 EE] stripos expects parameter string, null given #35542
Comments
Hi @sheepfy. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Hotel. Thank you for working on this issue.
|
Hello @sheepfy, Thanks for the posting and collaboration! We have checked the usage of function Please let us know which 3rd party module you have tried where you are facing the issue. Thanks |
@engcom-Hotel Hey, so it is about implementing Tab forms in admin. However, since _nameInLayout can reach as null in that method output, I'll stick to this: |
Hello @sheepfy, Thanks for the response! I have tried to check the above-mentioned modules in Marketplace and found the below results:
I request you to please connect with them and raise a query for this. They might help you. Thanks |
Dear @sheepfy, We have noticed that this issue has not been updated for a period of 14 Days. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this. Regards |
@engcom-Hotel hi, I don't think I can create a PR here with that fix tho, Magento\PricePermissions it's an enterprise module. |
@sheepfy I had this same issue and created a patch for it. This code can be saved as a .patch file and placed in /m2-hotfixes
|
@kmosdev Hi! file: magentoroot/patches/composer/github-issue-35542.diff diff --git a/Observer/AdminhtmlBlockHtmlBeforeObserver.php b/Observer/AdminhtmlBlockHtmlBeforeObserver.php
index 974b4ec..1978e66 100644
--- a/Observer/AdminhtmlBlockHtmlBeforeObserver.php
+++ b/Observer/AdminhtmlBlockHtmlBeforeObserver.php
@@ -118,6 +118,9 @@ class AdminhtmlBlockHtmlBeforeObserver implements ObserverInterface
{
/** @var $block Template */
$block = $observer->getBlock();
+ if (!$block->getNameInLayout()) {
+ return;
+ }
$this->_filterByBlockName($block); file: magentoroot/composer.json
|
@kmosdev How did you create that patch? |
Edited From After submited account creation
|
This fixed an issue on my Commerce edition on version 2.4.5-p1 in which I was getting the same error on a 3rd party module, patching the core magento vendor file as suggested worked wonders, thank you |
Hi, ValueError: bcsub(): Argument #1 ($num1) is not well-formed in /var/www/html/vendor/magento/zendframework1/library/Zend/Locale/Math.php:259 |
Hi team. I had the same problem when upgrading With a third-party module @plumrocket plumrocket/module-datagenerator:2.6.11 marketplace.magento I hope it can be useful Regards SequenceMenu > Plumrocket > Data Feed Generator > Manage Data Feed List > Enter a list itemLogs
Solution https://github.com//issues/35542#issuecomment-1173031379
|
This is still a problem on 2.4.5-p3 and patch had to be re-applied |
Still a problem on 2.4.6-p3 as well. |
v2.4.5-p5 and the issue is still there |
Hi @engcom-November. Thank you for working on this issue.
|
Reopening this issue, we will start looking into this. Thanks. |
For module developers: |
Hello @sheepfy, By looking into the codebase, we can confirm this issue, if Hence confirming the issue. Thanks |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-10560 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue. |
Hi, so we have this:
My issue:
I'm using a 3rd party module that adds Tabs in it's admin form and I am thinking of adding this condition in AdminhtmlBlockHtmlBeforeObserver::execute :
I don't think there is a reason to check anything in that observer if the block name is missing. (even if it's empty string).
Either that, either if the block name is not intended to be NULL update the getNameInLayout() to return only string.
The text was updated successfully, but these errors were encountered: