Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip Code for Greece should not expect space #36676

Closed
5 tasks
cptX opened this issue Dec 27, 2022 · 9 comments · Fixed by #36696
Closed
5 tasks

Zip Code for Greece should not expect space #36676

cptX opened this issue Dec 27, 2022 · 9 comments · Fixed by #36696
Assignees
Labels
Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@cptX
Copy link

cptX commented Dec 27, 2022

Preconditions and environment

  • Magento version
    2.4.5

Steps to reproduce

Go to cart or checkout, select Greece and insert postal code 12345

Expected result

No warning

Actual result

Zipcode gives warning

Additional information

Solution (completely written out, just copy and paste!)

Replace zip countrycode NL with:

    <zip countryCode="GR">
        <codes>
            <code id="pattern_1" active="true" example="12345">^[0-9]{5}$</code>
        </codes>
    </zip>

in /app/code/Magento/Directory/etc/zip_codes.xml

Release note

I'm 41 years old and I have never seen anyone write a zip code with a space in between here in Greece.
So getting an error/warning during ZIP Code input is definitely frustrating!
I have seen that several other countries face the same problem with this validation. For Greece I can ensure you that everybody writes the Zip code like this 12345 and not 123 45.
Even if you check the wikipedia you will see that actually there is a categorization defined by the first 2 digits and not 3, so in any case the current implementation is wrong. As far as I know everybody writes all 5 digits together. You can check this also here which gives a list with all zip codes and they give them as continues 5 digit numbers.

I would like also to reference this issue which is similar and with the same solution.
#11898

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Dec 27, 2022

Hi @cptX. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Dec 27, 2022

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Hotel engcom-Hotel added the Reported on 2.4.5 Indicates original Magento version for the Issue report. label Dec 28, 2022
@engcom-Dash
Copy link
Contributor

Hi @cptX ,

We are trying to reproduce the issue in 2.4.5 Magento instance its reproducible and we are confirming the issue.
Magento Version:2.4.5
PHP Version :8.1
Steps we Followed:
1.Install fresh Magento instance
2.Go to front end and add simple product in to cart
3.go to checkout
4.Select country as Greece
5.Enter postal code as 12345
Warning Message is Under the Postal code text box.As per description we getting same results.So we are confirming the issue.
For your reference attached the screenshots here:
Screenshot 2022-12-28 at 8 22 27 PM

Let us know if we missing anything!!!
Thanks!!!

@engcom-Dash engcom-Dash added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 28, 2022
@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 28, 2022
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@m2-community-project m2-community-project bot added Issue: ready for confirmation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Dec 28, 2022
@engcom-Dash engcom-Dash added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI labels Dec 28, 2022
@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 28, 2022
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7551 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Dec 28, 2022

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@cptX
Copy link
Author

cptX commented Dec 28, 2022

Thank you for focusing on this issue so quickly!

@Vasudev-22
Copy link
Contributor

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

5 participants