Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip code Netherlands should allow zipcode without space #11898

Closed
sschurink opened this issue Oct 31, 2017 · 9 comments
Closed

Zip code Netherlands should allow zipcode without space #11898

sschurink opened this issue Oct 31, 2017 · 9 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@sschurink
Copy link

Issue

Zip code validation warning on adresses from Netherlands.
Current validation is 1234 AA
This should also allow zipcode without space 1234AA

Preconditions

On all 2.* versions including development branch.

Steps to reproduce

go to cart or checkout, select Netherlands and insert postal code 1234AA

Expected result

No warning

Actual result

Zipcode gives warning

Solution (completely written out, just copy and paste!)

Replace zip countrycode NL with:

 <zip countryCode="NL">
      <codes>
        <code id="pattern_1" active="true" example="1234 AB/1234AB">^[0-9]{4}\s?[a-zA-Z]{2}$</code>
      </codes>
    </zip> 

in /app/code/Magento/Directory/etc/zip_codes.xml

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Oct 31, 2017
@magento-engcom-team
Copy link
Contributor

@sschurink, thank you for your report.
We've created internal ticket(s) MAGETWO-83058 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 31, 2017
@osrecio
Copy link
Member

osrecio commented Nov 2, 2017

Working on it

@ishakhsuvarov
Copy link
Contributor

Hi @sschurink
According to this information from the post.nl website it is recommended to separate postal code digits and letters with a space.
Do you have any additional information on this?
Thanks

@sschurink
Copy link
Author

sschurink commented Nov 3, 2017 via email

@ishakhsuvarov
Copy link
Contributor

@sschurink Thank you for the update.

okorshenko pushed a commit that referenced this issue Nov 3, 2017


 - Merge Pull Request #11960 from osrecio/magento2:PR#NL_PostCode_2.1
 - Merged commits:
   1. b891a0c
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-83195

okorshenko pushed a commit that referenced this issue Nov 4, 2017
 - Merge Pull Request #11959 from osrecio/magento2:PR#NL_PostCode
 - Merged commits:
   1. 9deda1c
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-83194

@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch and will be available with 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 4, 2017
okorshenko pushed a commit that referenced this issue Nov 4, 2017


 - Merge Pull Request #11961 from osrecio/magento2:PR#NL_PostCode_2.3
 - Merged commits:
   1. b5caeca
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-83196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants