Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11898 - Change NL PostCode Pattern #11959

Merged
merged 1 commit into from
Nov 4, 2017
Merged

#11898 - Change NL PostCode Pattern #11959

merged 1 commit into from
Nov 4, 2017

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Nov 2, 2017 •
edited by tadeobarranco
Loading

Change Pattern for NL PostCodes

Description

Change Pattern for NL PostCodes based in: http://html5pattern.com/Postal_Codes (Dutch Postal Code)

Fixed Issues (if relevant)

  1. Zip code Netherlands should allow zipcode without space #11898: Zip code Netherlands should allow zipcode without space

Manual testing scenarios

  1. Buy Product
  2. Go Checkout
  3. Select Netherlands Country
  4. Put PostCode: 1234 AA

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Nov 2, 2017
@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 2, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 2, 2017
@okorshenko okorshenko merged commit 9deda1c into magento:2.2-develop Nov 4, 2017
okorshenko pushed a commit that referenced this pull request Nov 4, 2017
MAGETWO-83194: #11898 - Change NL PostCode Pattern #11959
bbfaa9c
@osrecio osrecio deleted the PR#NL_PostCode branch November 4, 2017 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@osrecio @magento-team @ishakhsuvarov @okorshenko